Use Output widget with Interact #7554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +34,10 @@ class Output(DOMWidget): | |||
| print('prints to output widget')""" | |||
| _view_name = Unicode('OutputView', sync=True) | |||
|
|
|||
| def __init__(self, *args, **kwargs): | |||
| super(Output, self).__init__(*args, **kwargs) | |||
| self._ip = get_ipython() | |||
There was a problem hiding this comment.
This file is missing from IPython import get_ipython
|
Travis failures look real. Missing |
jdfreder
force-pushed
the
interact-fix
branch
from
6632b63
to
996c4d7
Compare
|
Tests are failing with a few off-by-one errors, but it looks like the tests need updating rather than an actual bug, since an extra widget is added to the collection. |
jdfreder
force-pushed
the
interact-fix
branch
from
996c4d7
to
79b63be
Compare
|
Looks like this is passing now. |
| @@ -80,7 +80,8 @@ def check_widgets(container, **to_check): | |||
| # build a widget dictionary, so it matches | |||
| widgets = {} | |||
| for w in container.children: | |||
| widgets[w.description] = w | |||
| if hasattr(w, 'description'): | |||
| widgets[w.description] = w | |||
There was a problem hiding this comment.
This means that widgets without a description will be excluded from the dict. Is there a problem with doing that?
There was a problem hiding this comment.
It shouldn't be a problem, widgets without descriptions cause this code (without the check) to barf, so they can't be included as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6534
alternative to #7482
Ping @jasongrout who was also interested in this solution.
Also this fixes a small bug in which
get_ipythonis not defined in the context where the Output widget is__enter__ed.