Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect IPython from bad custom exception handlers #876

Merged
merged 7 commits into from
Oct 16, 2011

Commits on Oct 14, 2011

  1. protect IPython from bad custom exception handlers

    Previously, errors in custom handlers would result in the custom exception
    handler's error being printed in lieu of the real exception, and certain cases could cause infinite loops.
    
    Now, if CustomTB fails it is unregistered immediately, and the original TB is also displayed.
    
    IPython's own BdbQuit_IPython_excepthook had an invalid signature, which revealed this issue, and has also been fixed.
    
    test included.
    
    closes ipython#692
    minrk committed Oct 14, 2011
    Configuration menu
    Copy the full SHA
    ed5078c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0d065b1 View commit details
    Browse the repository at this point in the history
  3. prevent atexit handlers from generating crash report

    register `sys.excepthook = sys.__excepthook__` with atexit on aplication startup,
    so it should be the first handler called.  This removes the crash handler.
    
    closes ipython#207
    minrk committed Oct 14, 2011
    Configuration menu
    Copy the full SHA
    d5548fa View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2011

  1. protect against bad return type of CustomTB

    includes test
    also expands a few docstrings
    minrk committed Oct 15, 2011
    Configuration menu
    Copy the full SHA
    09803ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e385f97 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    09c2492 View commit details
    Browse the repository at this point in the history
  4. re-enable pydb flag

    Note that pydb has been deprecated, and superseded by pydbgr, which may be
    abandoned.
    
    It would be preferable if the Pdb class could inherit from pydb or pdb
    based on a runtime flag rather than checking sys.argv at the top level.
    This at least restores old behavior for pydb users.
    
    closes ipython#636
    minrk committed Oct 15, 2011
    Configuration menu
    Copy the full SHA
    d16b38e View commit details
    Browse the repository at this point in the history