Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SingletonConfigurable a subclass of LoggingConfigurable #118

Closed
Carreau opened this issue Nov 6, 2015 · 1 comment
Closed

make SingletonConfigurable a subclass of LoggingConfigurable #118

Carreau opened this issue Nov 6, 2015 · 1 comment
Milestone

Comments

@Carreau
Copy link
Member

Carreau commented Nov 6, 2015

Most subclass of SingletonConfigurable are Applications that redefine a log trait.

Exception is InteractiveShell in IPython which define the old way a self.logger. And LaTeXTool in IPython that does not use log.

Once this is done we can do that in load config (roughly):

if name in traits:
   ...
elif isinstance(self, LoggingConfigurable):
       from difflib import get_close_matches
       m = get_close_matches(name, traits)
       if m:
           self.log("{} not in config, do you mean one of: {}".format(name, m))  
@minrk
Copy link
Member

minrk commented Nov 6, 2015

fine with me.

@minrk minrk added this to the 4.1 milestone Aug 4, 2016
@minrk minrk closed this as completed Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants