copy self.config in update_config #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
changed the title
minrk
changed the title
protects IPython's CLI priority, which accidentally relies upon self.config being replaced during load_config_files. for backport to 4.2.2
| @@ -187,6 +187,10 @@ def _config_changed(self, change): | |||
|
|
|||
| def update_config(self, config): | |||
| """Update config and load the new values""" | |||
There was a problem hiding this comment.
Given these specific semantics (deepcopy first before update), I think it would be a good idea to extend a little bit the docstring with a note that indicates that's what happens, so it becomes clearly official that such semantics are the intended ones.
|
Other than my small and easy to address comments, +1 for merging. |
|
Comment updated, let me know if I can do anything else to make the situation clearer. |
it shouldn't be required, but we are doing it for backward-compatibility
|
Much better, thanks! I think that's clear enough, let's move forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protects IPython's CLI priority, which accidentally relies upon self.config being replaced during load_config_files.
for backport to 4.2.2
closes #248