always override config files with CLI options #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
force-pushed
the
cli-priority-part-2-boogaloo-and-such
branch
from
9a1f321
to
809ce98
Compare
|
+1, logic looks good, and the small changes I suggested to #249 should propagate cleanly upon rebase. |
- save cli_config in Application.cli_config - apply cli_config to config from files prior to loading, so that any lower-probity changes are never loaded by the application, rather than requiring load and re-load to preserve order
minrk
force-pushed
the
cli-priority-part-2-boogaloo-and-such
branch
from
809ce98
to
a6852ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes #249, so will need a rebase after that's merged
This is done in all IPython and Jupyter traitlets Applications, but not implemented in the base Application class until now.
so that any lower-priority changes in config files are never loaded by the application,
rather than requiring load and re-load to preserve priority.
avoids bugs like #248 by applying CLI config priority in load_config_file instead of relying on applications to implement it.
If we want to preserve prior behavior of load_config_file clobbering CLI config, we can put this behavior beind an optional flag in load_config_file or an attribute on Application.