Support for 12 or 24 words. #1179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for 12 or 24 words. Improvements on error handling.
|
@gilmarwsr sorry this went by the wayside. For some reason the tests didn't run, mind giving it another push? |
Comment on lines
+18
to
+28
| /// BIP39 can't find the word in the selected wordlist. | ||
| Bip39InvalidWord, | ||
|
|
||
| /// BIP39-related errors. | ||
| Bip39InvalidPhraseSize, | ||
|
|
||
| ///BIP39 entropy must have 16 or 32 bytes | ||
| Bip39InvalidEntropySize, | ||
|
|
||
| ///BIP39 invalid checksum | ||
| Bip39InvalidChecksum, |
There was a problem hiding this comment.
Instead of making several Bip39-prefixed variants, I think it would be better to have Bip39(bip39::Error) and a subdivided error type concerned with just those failure modes, even if that's a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for 12 or 24 words.
Improvements on error handling.