tx-signer: add a third retry for failed transactions #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we encounter an error broadcasting a transaction, we don't know if it actually went on to succeed or not. If it did, we need to increment the sequence number. Ideally we could simply query the chain for either the transaction to see if it was actually broadcast or to simply check the current sequence number so we could resynchronize in this case, but we can't do that until after Tendermint v0.34-related protobuf upgrades. In the meantime, this commit puts a band-aid on a band-aid and adds a third retry in these scenarios, which are happening several times a week. If this doesn't address it, the retry logic could be extended into a loop, but that gets tricky.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we encounter an error broadcasting a transaction, we don't know if it actually went on to succeed or not. If it did, we need to increment the sequence number.
Ideally we could simply query the chain for either the transaction to see if it was actually broadcast or to simply check the current sequence number so we could resynchronize in this case, but we can't do that until after Tendermint v0.34-related protobuf upgrades.
In the meantime, this commit puts a band-aid on a band-aid and adds a third retry in these scenarios, which are happening several times a week.
If this doesn't (temporarily) address it, the retry logic could be extended into a loop, but that gets tricky.