Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyring: initial ECDSA support (YubiHSM2 only) #76

Merged
merged 1 commit into from Jun 15, 2020
Merged

Conversation

tony-iqlusion
Copy link
Member

@tony-iqlusion tony-iqlusion commented Jun 15, 2020

Adds initial support for storing ECDSA keys (i.e. account keys) in per-chain keyrings, initially wired up for the yubihsm provider.

There's no code to actually use these keys yet. That will come in follow-up PR(s).

Adds initial support for storing ECDSA keys (i.e. account keys) in
per-chain keyrings, initially wired up for the `yubihsm` provider.

There's no code to actually use these keys yet. That will come in
follow-up PR(s).
@tony-iqlusion tony-iqlusion requested a review from zmanian Jun 15, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020

Codecov Report

Merging #76 into develop will decrease coverage by 0.91%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #76      +/-   ##
===========================================
- Coverage    28.54%   27.63%   -0.92%     
===========================================
  Files           50       52       +2     
  Lines         1867     1929      +62     
===========================================
  Hits           533      533              
- Misses        1334     1396      +62     
Impacted Files Coverage Δ
src/chain/registry.rs 0.00% <0.00%> (ø)
src/commands/yubihsm/keys/list.rs 0.00% <ø> (ø)
src/config/provider.rs 0.00% <0.00%> (ø)
src/config/provider/yubihsm.rs 0.00% <ø> (ø)
src/keyring.rs 0.00% <0.00%> (ø)
src/keyring/ecdsa.rs 0.00% <0.00%> (ø)
src/keyring/ed25519.rs 0.00% <ø> (ø)
src/keyring/providers/ledgertm.rs 0.00% <0.00%> (ø)
src/keyring/providers/softsign.rs 0.00% <0.00%> (ø)
src/keyring/providers/yubihsm.rs 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c457f...bf19963. Read the comment docs.

@tony-iqlusion tony-iqlusion merged commit 2685e78 into develop Jun 15, 2020
10 checks passed
@tony-iqlusion tony-iqlusion deleted the ecdsa branch Jun 15, 2020
This was referenced Jun 23, 2020
@tony-iqlusion tony-iqlusion mentioned this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants