keyring: initial ECDSA support (YubiHSM2 only) #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds initial support for storing ECDSA keys (i.e. account keys) in per-chain keyrings, initially wired up for the `yubihsm` provider. There's no code to actually use these keys yet. That will come in follow-up PR(s).
Codecov Report
@@ Coverage Diff @@
## develop #76 +/- ##
===========================================
- Coverage 28.54% 27.63% -0.92%
===========================================
Files 50 52 +2
Lines 1867 1929 +62
===========================================
Hits 533 533
- Misses 1334 1396 +62
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial support for storing ECDSA keys (i.e. account keys) in per-chain keyrings, initially wired up for the
yubihsmprovider.There's no code to actually use these keys yet. That will come in follow-up PR(s).