Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appropriate server defaults #64

Closed
kuriwaki opened this issue Dec 27, 2020 · 0 comments
Closed

Appropriate server defaults #64

kuriwaki opened this issue Dec 27, 2020 · 0 comments
Labels
data-download Functions that are about downloading, not uploading, data documentation question
Milestone

Comments

@kuriwaki
Copy link
Member

kuriwaki commented Dec 27, 2020

tldr: Help pages and tests should specify a server, either via Sys.setenv("DATAVERSE_SERVER" = "havard.dataverse.edu") OR specifying server = "harvard.dataverse.edu" each time.

Background: The server argument used in most of the functions has the default Sys.getenv("DATAVERSE_SERVER"), which means that the initial user would get a "server not specified" error when trying out the help page examples.

So shouldn't all minimal working examples specify a server argument?

Also this default is inconsistent with the documentation, which says (emphasis mine)

A character string specifying a Dataverse server. There are multiple Dataverse installations, but the defaults is to use the Harvard Dataverse. This can be modified atomically or globally using Sys.setenv("DATAVERSE_SERVER" = "dataverse.example.com").

@kuriwaki kuriwaki added question documentation data-download Functions that are about downloading, not uploading, data labels Dec 27, 2020
@kuriwaki kuriwaki added this to the CRAN 0.3.10 milestone Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-download Functions that are about downloading, not uploading, data documentation question
Projects
None yet
Development

No branches or pull requests

1 participant