Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deaccession: deaccessioner can not see metadata nor perform many actions #1267

Closed
pdurbin opened this issue Dec 17, 2014 · 11 comments
Closed

Comments

@pdurbin
Copy link
Member

pdurbin commented Dec 17, 2014

According to the Deaccessioning design doc, "Only the owner (others with permission) will have a link in the versions tab so that they may see the metadata/files associated with the deaccessioned version." (emphasis added)

Probably due to changes in permissions, it is not possible for anyone (even admin!) to see the metadata for the deaccessioned dataset. (There is no "Metadata" tab.) I'm sure an admin might be interested in looking into the details of why a dataset was deaccessioned, beyond the reason given on the version tab. They might want to look at the metadata or the files.

The dataset creator might want to create a new version of the dataset based on the deaccessioned version.

Screenshot:

spruce_goose_-spruce_dataverse-_2014-12-17_09 07 34

@rmo-cdsp
Copy link
Contributor

rmo-cdsp commented Oct 1, 2015

You still can't see metadatas of the deaccessioned dataset as creator.
Also, if you create a draft version of a dataset, then deaccession it, you will keep a draft version of the dataset, ready to publish later. But, if you deaccession a dataset, you can't make a draft version of it any more. Maybe allowing , to the creator, to create a draft version of a deaccessioned dataset would solve some "problems" with that issue ?

@mheppler mheppler added Feature: Permissions and removed UX & UI: Design This issue needs input on the design of the UI and from the product owner labels Jan 27, 2016
@scolapasta scolapasta removed their assignment Jan 27, 2016
@scolapasta scolapasta removed this from the Not Assigned to a Release milestone Jan 28, 2016
@mheppler mheppler changed the title Deaccessioning: deaccessioner can not see metadata nor perform many actions Deaccession: deaccessioner can not see metadata nor perform many actions Jan 29, 2016
@mheppler
Copy link
Contributor

In addition to not being able to see the Metadata, the Version tab reads, "No records found" when there are in fact other published/draft version.

screen shot 2016-10-20 at 4 03 12 pm

@mheppler
Copy link
Contributor

Related to #1308.

@mheppler mheppler added the ready label Oct 20, 2016
@djbrooke djbrooke added ready and removed ready labels Oct 24, 2016
@sekmiller sekmiller self-assigned this Oct 24, 2016
@djbrooke djbrooke added this to the 4.6 - File Replace milestone Oct 24, 2016
@djbrooke
Copy link
Contributor

@sekmiller what's the correct state of this one? Should this be in Development?

@sekmiller
Copy link
Contributor

@djbrooke Can probably go directly into QA. There's nothing notable about the code changes.

@mheppler
Copy link
Contributor

mheppler commented Oct 25, 2016

When the Versions table is displayed, there is no version number displayed in the first column if you are an end user without access to view that version (see attached). Instead of an empty version number table cell, we should put a static text version number.

screen shot 2016-10-25 at 4 35 08 pm

@djbrooke
Copy link
Contributor

Had a brief discussion about this in standup 10/25. This is ready for code review, but the fix is on the file landing page branch. I'm going to move it to the bottom of the development column in Waffle for now.

@pdurbin
Copy link
Member Author

pdurbin commented Nov 4, 2016

@sekmiller was this fixed by b5b5f31?

@pdurbin
Copy link
Member Author

pdurbin commented Nov 7, 2016

@sekmiller and I just spoke about how b5b5f31 indeed should be a fix for this issue so he said this issue should go to QA. I associated it with pull request #3408.

@mheppler
Copy link
Contributor

mheppler commented Nov 7, 2016

Based on feedback from @mcrosas, hid the "Share" button in deaccessioned view on dataset and file pgs.

@kcondon
Copy link
Contributor

kcondon commented Nov 8, 2016

All good, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants