Merged
Conversation
…e thumbnail render logic, added placeholder tabs for Provenance and Versions. [ref #2295]
… buttons) on file pg. [ref #2465]
…nto file-metadata-provenance-2295
… of Dataset Page
…le pg and dataset pg. [ref #2465]
…s on the file pg. [ref #2465]
only a difference in whitespace in mD5-block Conflicts: src/main/webapp/file.xhtml
pdurbin
reviewed
Oct 17, 2016
| <!-- FIXME: When this page is fixed (no more "Method isThumbnailAvailable not found") also replace "file.MD5" with FilePage.file.checksumType and "file.MD5.origal" with "file.originalChecksumType" --> | ||
| <h:outputText id="fileMD5" value="#{FilePage.file.tabularData ? bundle['file.MD5.origal'] : bundle['file.MD5']}: #{FilePage.file.checksumValue};" | ||
| <div class="mD5-block" jsf:rendered="#{!FilePage.file.tabularData}"> | ||
| <!-- FIXME: When this page is fixed (no more "Method isThumbnailAvailable not found") --> |
Member
There was a problem hiding this comment.
It looks like the FIXME has been addressed so the comment should be removed.
…t Access button block on File pg. [ref #2465]
and remove request access to deaccessioned files
…) for deacessioned datasets/files of Download/Request Access button block on File pg. [ref #2465]
… in the file-button fragment. [ref #2465]
…oad, so that it doesn't trigger a download count increment/guestbook entrie.
and Open Explore in same tab
Contributor
|
OK, looks good. |
pdurbin
added this to the
4.6 - File Page, Harvesting Enhancements, Upload Enhancements milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFI Checklist
Before submitting the pull request, fill out sections (1.) Related Issues and (2.) Pull Request Checklist.
1. Related Issues
List and link to the issues in this Pull Request.
2. Pull Request Checklist
3. Review Checklist
After the pull request has been submitted, fill out this section.
Connects to #2465
Connects to #1267
Connects to #1308
Connects to #3451