Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper response for unknown command #8

Closed
mickeyl opened this issue Mar 7, 2021 · 1 comment
Closed

Proper response for unknown command #8

mickeyl opened this issue Mar 7, 2021 · 1 comment

Comments

@mickeyl
Copy link

mickeyl commented Mar 7, 2021

The unknown command case is handled wrongly – a real ELM327 (and the behemoth of clones) answers with ?\r\r, not just \r – the question mark is very important.

Reasoning: Said answer is very important, since it is good practice to start the ELM327 probing sequence by sending an invalid command, such as .\r, to ensure a consistent state of the send buffer – hence clients need to rely on a proper answer for unknown command.

@Ircama
Copy link
Owner

Ircama commented Mar 7, 2021

Software changed to manage the invalid answer message in ELM_R_UNKNOWN, which defaults to ?\r\r and can be changed. Documentation updated accordingly.

@Ircama Ircama closed this as completed in 4b543f0 Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants