Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake consistency sweep for 4.3.1 post-release #7265

Open
10 of 15 tasks
SwooshyCueb opened this issue Aug 16, 2023 · 0 comments
Open
10 of 15 tasks

CMake consistency sweep for 4.3.1 post-release #7265

SwooshyCueb opened this issue Aug 16, 2023 · 0 comments
Assignees
@SwooshyCueb
Labels
build/tools
Milestone
4.3.4

Comments

@SwooshyCueb
Copy link
Member

SwooshyCueb commented Aug 16, 2023 •
edited
Loading

More will probably be added to this list

  • irods_project_template_cpp_api_plugin
  • irods_project_template_cpp_client
  • irods_project_template_cpp_microservice
  • irods_project_template_cpp_resource_plugin
  • irods_project_template_cpp_rule_engine_plugin
  • irods_netcdf
  • irods_client_s3_api
  • irods_client_http_api
  • irods_resource_plugin_s3
  • irods_client_cli
  • irods_client_globus_connector
  • irods_auth_plugin_pam_interactive
  • irods_capability_indexing
  • irods_capability_storage_tiering
  • irods_auth_plugin_pam_interactive
@SwooshyCueb SwooshyCueb added this to the 4.3.2 milestone Aug 16, 2023
@SwooshyCueb SwooshyCueb self-assigned this Aug 16, 2023
@SwooshyCueb SwooshyCueb mentioned this issue Aug 16, 2023
Closed
11 tasks
@SwooshyCueb SwooshyCueb mentioned this issue Aug 24, 2023
Closed
11 tasks
@SwooshyCueb SwooshyCueb mentioned this issue Sep 8, 2023
Closed
14 tasks
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_api_plugin that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: pass plugin version to project call
3a05feb
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_api_plugin that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: allow usage of find module for irods
bfc2d97
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_api_plugin that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: use IrodsRunpathDefaults
7904efb
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_api_plugin that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: set IRODS_PACKAGE_REVISION to 0
a3a0dce
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_api_plugin that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: Add toggle for -Werror
bd51a2b
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_api_plugin that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: Remove private generator expression
599be21
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_api_plugin that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: CMAKE_SOURCE_DIR -> CMAKE_CURRENT_SOURCE_DIR
fff54e0
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_api_plugin that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: quote paths
65b1ec8
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_api_plugin that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: do not set CMAKE_EXPORT_COMPILE_COMMANDS
92d6ee7
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: pass plugin version to project call
fcd1540
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: allow usage of find module for irods
48586fa
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: set CMAKE_CXX_EXTENSIONS
90b4970
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: use IrodsRunpathDefaults
9d3a2a7
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: Add toggle for -Werror
019fdce
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: CMAKE_SOURCE_DIR -> CMAKE_CURRENT_SOURCE_DIR
9b2f7a9
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: quote paths
74eb8c9
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: do not set CMAKE_EXPORT_COMPILE_COMMANDS
9faca23
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] CMake: avoid generic variable name EXECUTABLE_NAME
03f630c
SwooshyCueb added a commit to SwooshyCueb/irods_project_template_cpp_api_plugin that referenced this issue Nov 1, 2023
@SwooshyCueb
[irods/irods#7265] Get package revision from IrodsCPackCommon
89eab32
korydraughn pushed a commit to irods/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb @korydraughn
[irods/irods#7265] CMake: pass plugin version to project call
ed1472c
korydraughn pushed a commit to irods/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb @korydraughn
[irods/irods#7265] CMake: allow usage of find module for irods
aed536e
korydraughn pushed a commit to irods/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb @korydraughn
[irods/irods#7265] CMake: set CMAKE_CXX_EXTENSIONS
275352e
korydraughn pushed a commit to irods/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb @korydraughn
[irods/irods#7265] CMake: use IrodsRunpathDefaults
050ba84
korydraughn pushed a commit to irods/irods_project_template_cpp_client that referenced this issue Nov 1, 2023
@SwooshyCueb @korydraughn
[irods/irods#7265] CMake: Add toggle for -Werror
f836bc2
SwooshyCueb added a commit to SwooshyCueb/irods_resource_plugin_s3 that referenced this issue Mar 6, 2024
@SwooshyCueb
[irods#2080,irods#2154,irods/irods#7265] Minor reorganization + CMake…
d0b987b 
… TLC

- Project tree structure reorganized to match that of main irods repo.
- Removed unused read_shared_memory.cpp.
- Fixed some system #includes not having angle brackets.
- Added quotes around paths in CMake files.
- Changed all instances of CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR.
- Removed CMAKE_SHARED_LINKER_FLAGS_INIT and
  CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT, as no shared libraries are built.
- Added IRODS_PLUGINS_DIRECTORY to
  CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION.
- Added CMAKE_EXE_LINKER_FLAGS_INIT and CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT
  for unit tests.
- [irods#2080] Rewrote unit test cmake to match that of main irods repo.
- [irods#2154] Replaced curl-devel package dependency declaration with libcurl
alanking pushed a commit to irods/irods_resource_plugin_s3 that referenced this issue Mar 6, 2024
@SwooshyCueb @alanking
[#2080,#2154,irods/irods#7265] Minor reorganization + CMake TLC
d9c7420 
- Project tree structure reorganized to match that of main irods repo.
- Removed unused read_shared_memory.cpp.
- Fixed some system #includes not having angle brackets.
- Added quotes around paths in CMake files.
- Changed all instances of CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR.
- Removed CMAKE_SHARED_LINKER_FLAGS_INIT and
  CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT, as no shared libraries are built.
- Added IRODS_PLUGINS_DIRECTORY to
  CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION.
- Added CMAKE_EXE_LINKER_FLAGS_INIT and CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT
  for unit tests.
- [#2080] Rewrote unit test cmake to match that of main irods repo.
- [#2154] Replaced curl-devel package dependency declaration with libcurl
This was referenced Mar 12, 2024
Merged
Merged
Merged
SwooshyCueb added a commit to SwooshyCueb/irods_capability_storage_tiering that referenced this issue Mar 13, 2024
@SwooshyCueb
[irods/irods#7265] Minor reorganization + CMake TLC
21ec213 
- Project tree structure reorganized to resemble that of main irods repo.
- Added quotes around paths in CMake files.
- Removed CMAKE_SHARED_LINKER_FLAGS_INIT and
  CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT, as no shared libraries are built.
- Changed all instances of CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR.
- Removed unneeded libarchive include dir
- Removed unneeded fmt linkage
- Removed unneeded libcrypto linkage
- Removed unneeded Threads::Threads linkage
- Added include guard to data_verification_utilities.hpp
- Added include guard to exec_as_user.hpp
- Added include guard to utilities.hpp
SwooshyCueb added a commit to SwooshyCueb/irods_capability_storage_tiering that referenced this issue Mar 13, 2024
@SwooshyCueb
[irods/irods#7265] Minor reorganization + CMake TLC
3d4cbff 
- Project tree structure reorganized to resemble that of main irods repo.
- Added quotes around paths in CMake files.
- Removed CMAKE_SHARED_LINKER_FLAGS_INIT and
  CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT, as no shared libraries are built.
- Changed all instances of CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR.
- Removed unneeded libarchive include dir
- Removed unneeded fmt linkage
- Removed unneeded libcrypto linkage
- Removed unneeded Threads::Threads linkage
- Added include guard to data_verification_utilities.hpp
- Added include guard to exec_as_user.hpp
- Added include guard to utilities.hpp
alanking pushed a commit to irods/irods_capability_storage_tiering that referenced this issue Mar 13, 2024
@SwooshyCueb @alanking
[irods/irods#7265] Minor reorganization + CMake TLC
30e77b1 
- Project tree structure reorganized to resemble that of main irods repo.
- Added quotes around paths in CMake files.
- Removed CMAKE_SHARED_LINKER_FLAGS_INIT and
  CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT, as no shared libraries are built.
- Changed all instances of CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR.
- Removed unneeded libarchive include dir
- Removed unneeded fmt linkage
- Removed unneeded libcrypto linkage
- Removed unneeded Threads::Threads linkage
- Added include guard to data_verification_utilities.hpp
- Added include guard to exec_as_user.hpp
- Added include guard to utilities.hpp
alanking pushed a commit to irods/irods_capability_storage_tiering that referenced this issue Mar 13, 2024
@SwooshyCueb @alanking
[irods/irods#7265] Minor reorganization + CMake TLC
2fee1a5 
- Project tree structure reorganized to resemble that of main irods repo.
- Added quotes around paths in CMake files.
- Removed CMAKE_SHARED_LINKER_FLAGS_INIT and
  CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT, as no shared libraries are built.
- Changed all instances of CMAKE_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR.
- Removed unneeded libarchive include dir
- Removed unneeded fmt linkage
- Removed unneeded libcrypto linkage
- Removed unneeded Threads::Threads linkage
- Added include guard to data_verification_utilities.hpp
- Added include guard to exec_as_user.hpp
- Added include guard to utilities.hpp
This was referenced Mar 13, 2024
Merged
Merged
Merged
SwooshyCueb added a commit to SwooshyCueb/irods_client_http_api that referenced this issue Mar 13, 2024
@SwooshyCueb
[irods/irods#7265] Add missing CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT
2f921d1
SwooshyCueb added a commit to SwooshyCueb/irods_client_http_api that referenced this issue Mar 13, 2024
@SwooshyCueb
[irods/irods#7265] Add missing CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT
85d10a1
SwooshyCueb added a commit to SwooshyCueb/irods_client_s3_api that referenced this issue Mar 13, 2024
@SwooshyCueb
[irods/irods#7265] Add missing CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT
2db964a
SwooshyCueb added a commit to SwooshyCueb/irods_client_s3_api that referenced this issue Mar 13, 2024
@SwooshyCueb
[irods/irods#7265] Remove unneeded curl linkage in s3 endpoints
2fc39b3
SwooshyCueb added a commit to SwooshyCueb/irods_capability_indexing that referenced this issue Mar 13, 2024
@SwooshyCueb
[irods/irods#7265] Minor reorganization + CMake TLC
752f650 
- Project tree structure reorganized to resemble that of main irods repo.
- Added quotes around paths in CMake files.
- Removed CMAKE_SHARED_LINKER_FLAGS_INIT and
  CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT, as no shared libraries are built.
- Removed unused postinst script for nonexistent data_world package
- Removed rpm package dependency declaration on openssl
- Fixed postinst CPack variables
alanking pushed a commit to irods/irods_client_http_api that referenced this issue Mar 14, 2024
@SwooshyCueb @alanking
[irods/irods#7265] Add missing CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT
99f07de
alanking pushed a commit to irods/irods_client_http_api that referenced this issue Mar 14, 2024
@SwooshyCueb @alanking
[irods/irods#7265] Add missing CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT
3ad6748
alanking pushed a commit to irods/irods_capability_indexing that referenced this issue Mar 14, 2024
@SwooshyCueb @alanking
[irods/irods#7265] Minor reorganization + CMake TLC
8ac1fa1 
- Project tree structure reorganized to resemble that of main irods repo.
- Added quotes around paths in CMake files.
- Removed CMAKE_SHARED_LINKER_FLAGS_INIT and
  CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT, as no shared libraries are built.
- Removed unused postinst script for nonexistent data_world package
- Removed rpm package dependency declaration on openssl
- Fixed postinst CPack variables
alanking pushed a commit to irods/irods_client_s3_api that referenced this issue Mar 14, 2024
@SwooshyCueb @alanking
[irods/irods#7265] Add missing CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT
2710265
alanking pushed a commit to irods/irods_client_s3_api that referenced this issue Mar 14, 2024
@SwooshyCueb @alanking
[irods/irods#7265] Remove unneeded curl linkage in s3 endpoints
f2c1bb6
@SwooshyCueb SwooshyCueb modified the milestones: 4.3.2, 4.3.3 Mar 25, 2024
@SwooshyCueb SwooshyCueb mentioned this issue Apr 25, 2024
Merged
SwooshyCueb added a commit to SwooshyCueb/irods_auth_plugin_pam_interactive that referenced this issue May 13, 2024
@SwooshyCueb @ll4strw
[irods#9,irods#14,irods#17,irods/irods#7265] Minor reorganization + C…
c0546c9 
…Make TLC

- removed unused `main.cpp`
- reorganized project
- created object library target for `auth_check_wrapper.cpp`
- created interface library target for `ipam_client.hpp`
- quoted paths in cmake
- Removed unneeded `CMAKE_SHARED_LINKER_FLAGS_INIT` and `CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT`
- Added missing `CMAKE_EXE_LINKER_FLAGS_INIT` and `CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT`
- Swapped quotes to angle brackets on irods includes
- Removed references to nonexistent include directory from cmake
- Removed unneeded `pam_conversation.hpp` include from `handshake_session.cpp`
- Bumped irods version and removed exact requirement
- Updated `CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION`
- Split into server and client packages (server package depends on client package)
- Replaced PAM `find_library` logic with a new find module
- Switched to `find_package` for fmt and spdlog

Co-authored-by: ll4strw <l.lenoci@science.leidenuniv.nl>
SwooshyCueb added a commit to SwooshyCueb/irods_auth_plugin_pam_interactive that referenced this issue May 23, 2024
@SwooshyCueb @ll4strw
[irods#9,irods#14,irods#17,irods/irods#7265] Minor reorganization + C…
3f3d21f 
…Make TLC

- removed unused `main.cpp`
- reorganized project
- created object library target for `auth_check_wrapper.cpp`
- created interface library target for `ipam_client.hpp`
- quoted paths in cmake
- Removed unneeded `CMAKE_SHARED_LINKER_FLAGS_INIT` and `CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT`
- Added missing `CMAKE_EXE_LINKER_FLAGS_INIT` and `CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT`
- Swapped quotes to angle brackets on irods includes
- Removed references to nonexistent include directory from cmake
- Removed unneeded `pam_conversation.hpp` include from `handshake_session.cpp`
- Bumped irods version and removed exact requirement
- Updated `CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION`
- Split into server and client packages (server package depends on client package)
- Replaced PAM `find_library` logic with a new find module
- Switched to `find_package` for fmt and spdlog

Co-authored-by: ll4strw <l.lenoci@science.leidenuniv.nl>
alanking pushed a commit to irods/irods_auth_plugin_pam_interactive that referenced this issue May 24, 2024
@SwooshyCueb @ll4strw @alanking
[#9,#14,#17,irods/irods#7265] Minor reorganization + CMake TLC
0dc86eb 
- removed unused `main.cpp`
- reorganized project
- created object library target for `auth_check_wrapper.cpp`
- created interface library target for `ipam_client.hpp`
- quoted paths in cmake
- Removed unneeded `CMAKE_SHARED_LINKER_FLAGS_INIT` and `CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT`
- Added missing `CMAKE_EXE_LINKER_FLAGS_INIT` and `CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT`
- Swapped quotes to angle brackets on irods includes
- Removed references to nonexistent include directory from cmake
- Removed unneeded `pam_conversation.hpp` include from `handshake_session.cpp`
- Bumped irods version and removed exact requirement
- Updated `CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION`
- Split into server and client packages (server package depends on client package)
- Replaced PAM `find_library` logic with a new find module
- Switched to `find_package` for fmt and spdlog

Co-authored-by: ll4strw <l.lenoci@science.leidenuniv.nl>
@SwooshyCueb SwooshyCueb modified the milestones: 4.3.3, 4.3.4 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SwooshyCueb SwooshyCueb

Labels
build/tools
Milestone
4.3.4
Development

No branches or pull requests
1 participant
@SwooshyCueb