Packaging is wrong in several ways #17
Comments
ll4strw
added a commit
to ll4strw/irods_auth_pam_interactive
that referenced
this issue
Apr 9, 2024
It produces two packages: one for the client wuth just the client-side plugin and one for the server which includes both the client and server plugins.
I think this is something that has to do with the way the pkg manager handles duplicates etc.. |
SwooshyCueb
added a commit
to SwooshyCueb/irods_auth_plugin_pam_interactive
that referenced
this issue
May 13, 2024
…Make TLC - removed unused `main.cpp` - reorganized project - created object library target for `auth_check_wrapper.cpp` - created interface library target for `ipam_client.hpp` - quoted paths in cmake - Removed unneeded `CMAKE_SHARED_LINKER_FLAGS_INIT` and `CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT` - Added missing `CMAKE_EXE_LINKER_FLAGS_INIT` and `CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT` - Swapped quotes to angle brackets on irods includes - Removed references to nonexistent include directory from cmake - Removed unneeded `pam_conversation.hpp` include from `handshake_session.cpp` - Bumped irods version and removed exact requirement - Updated `CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION` - Split into server and client packages (server package depends on client package) - Replaced PAM `find_library` logic with a new find module - Switched to `find_package` for fmt and spdlog Co-authored-by: ll4strw <l.lenoci@science.leidenuniv.nl>
SwooshyCueb
added a commit
to SwooshyCueb/irods_auth_plugin_pam_interactive
that referenced
this issue
May 23, 2024
…Make TLC - removed unused `main.cpp` - reorganized project - created object library target for `auth_check_wrapper.cpp` - created interface library target for `ipam_client.hpp` - quoted paths in cmake - Removed unneeded `CMAKE_SHARED_LINKER_FLAGS_INIT` and `CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT` - Added missing `CMAKE_EXE_LINKER_FLAGS_INIT` and `CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT` - Swapped quotes to angle brackets on irods includes - Removed references to nonexistent include directory from cmake - Removed unneeded `pam_conversation.hpp` include from `handshake_session.cpp` - Bumped irods version and removed exact requirement - Updated `CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION` - Split into server and client packages (server package depends on client package) - Replaced PAM `find_library` logic with a new find module - Switched to `find_package` for fmt and spdlog Co-authored-by: ll4strw <l.lenoci@science.leidenuniv.nl>
alanking
pushed a commit
that referenced
this issue
May 24, 2024
- removed unused `main.cpp` - reorganized project - created object library target for `auth_check_wrapper.cpp` - created interface library target for `ipam_client.hpp` - quoted paths in cmake - Removed unneeded `CMAKE_SHARED_LINKER_FLAGS_INIT` and `CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT` - Added missing `CMAKE_EXE_LINKER_FLAGS_INIT` and `CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT` - Swapped quotes to angle brackets on irods includes - Removed references to nonexistent include directory from cmake - Removed unneeded `pam_conversation.hpp` include from `handshake_session.cpp` - Bumped irods version and removed exact requirement - Updated `CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION` - Split into server and client packages (server package depends on client package) - Replaced PAM `find_library` logic with a new find module - Switched to `find_package` for fmt and spdlog Co-authored-by: ll4strw <l.lenoci@science.leidenuniv.nl>
|
Should be fixed with #21. If further changes are needed, please open a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I goofed up the packaging in 8bfa0f6 :(
Only 1 package is produced and we need to be producing 2 packages: one for the client (just the client-side plugin) and one for the server (which includes both the client and server plugins, as well as any tests which will come in the future).
Also, there may be an issue with upgrading/replacing installed files which already exist. May or may not be related.
This is a blocker for release.
The text was updated successfully, but these errors were encountered: