Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize source files and header files #14

Closed
alanking opened this issue Feb 22, 2024 · 2 comments
Closed

Reorganize source files and header files #14

alanking opened this issue Feb 22, 2024 · 2 comments
Assignees
@SwooshyCueb
Labels
build/tools
Milestone
4.3.1.0

Comments

@alanking
Copy link
Contributor

We should move header files to an include/ directory.

ipam_client might need to be removed or separated.

pam_interactive.cpp should probably be main.cpp.
@alanking alanking added this to the 4.3.1.0 milestone Feb 22, 2024
@alanking
Copy link
Contributor Author

Also need to look into separating pam_handshake_auth_check executable. This is being used by the server-side plugin, but it may behoove us to make its own CMakeLists file for clarity and separation of concerns.

@alanking alanking mentioned this issue Feb 23, 2024
Merged
7 tasks
@SwooshyCueb SwooshyCueb mentioned this issue Apr 25, 2024
Merged
SwooshyCueb added a commit to SwooshyCueb/irods_auth_plugin_pam_interactive that referenced this issue May 13, 2024
@SwooshyCueb @ll4strw
[irods#9,irods#14,irods#17,irods/irods#7265] Minor reorganization + C…
c0546c9 
…Make TLC

- removed unused `main.cpp`
- reorganized project
- created object library target for `auth_check_wrapper.cpp`
- created interface library target for `ipam_client.hpp`
- quoted paths in cmake
- Removed unneeded `CMAKE_SHARED_LINKER_FLAGS_INIT` and `CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT`
- Added missing `CMAKE_EXE_LINKER_FLAGS_INIT` and `CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT`
- Swapped quotes to angle brackets on irods includes
- Removed references to nonexistent include directory from cmake
- Removed unneeded `pam_conversation.hpp` include from `handshake_session.cpp`
- Bumped irods version and removed exact requirement
- Updated `CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION`
- Split into server and client packages (server package depends on client package)
- Replaced PAM `find_library` logic with a new find module
- Switched to `find_package` for fmt and spdlog

Co-authored-by: ll4strw <l.lenoci@science.leidenuniv.nl>
SwooshyCueb added a commit to SwooshyCueb/irods_auth_plugin_pam_interactive that referenced this issue May 23, 2024
@SwooshyCueb @ll4strw
[irods#9,irods#14,irods#17,irods/irods#7265] Minor reorganization + C…
3f3d21f 
…Make TLC

- removed unused `main.cpp`
- reorganized project
- created object library target for `auth_check_wrapper.cpp`
- created interface library target for `ipam_client.hpp`
- quoted paths in cmake
- Removed unneeded `CMAKE_SHARED_LINKER_FLAGS_INIT` and `CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT`
- Added missing `CMAKE_EXE_LINKER_FLAGS_INIT` and `CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT`
- Swapped quotes to angle brackets on irods includes
- Removed references to nonexistent include directory from cmake
- Removed unneeded `pam_conversation.hpp` include from `handshake_session.cpp`
- Bumped irods version and removed exact requirement
- Updated `CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION`
- Split into server and client packages (server package depends on client package)
- Replaced PAM `find_library` logic with a new find module
- Switched to `find_package` for fmt and spdlog

Co-authored-by: ll4strw <l.lenoci@science.leidenuniv.nl>
alanking pushed a commit that referenced this issue May 24, 2024
@SwooshyCueb @ll4strw @alanking
[#9,#14,#17,irods/irods#7265] Minor reorganization + CMake TLC
0dc86eb 
- removed unused `main.cpp`
- reorganized project
- created object library target for `auth_check_wrapper.cpp`
- created interface library target for `ipam_client.hpp`
- quoted paths in cmake
- Removed unneeded `CMAKE_SHARED_LINKER_FLAGS_INIT` and `CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT`
- Added missing `CMAKE_EXE_LINKER_FLAGS_INIT` and `CMAKE_EXE_LINKER_FLAGS_RELEASE_INIT`
- Swapped quotes to angle brackets on irods includes
- Removed references to nonexistent include directory from cmake
- Removed unneeded `pam_conversation.hpp` include from `handshake_session.cpp`
- Bumped irods version and removed exact requirement
- Updated `CPACK_RPM_EXCLUDE_FROM_AUTO_FILELIST_ADDITION`
- Split into server and client packages (server package depends on client package)
- Replaced PAM `find_library` logic with a new find module
- Switched to `find_package` for fmt and spdlog

Co-authored-by: ll4strw <l.lenoci@science.leidenuniv.nl>
@SwooshyCueb
Copy link
Member

If any further reorganization is needed post-#21, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SwooshyCueb SwooshyCueb

Labels
build/tools
Projects
None yet
Milestone
4.3.1.0
Development

No branches or pull requests
2 participants
@SwooshyCueb @alanking