Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn test:watch failing. Missing git/hg? #864

Closed
AmberKiso opened this issue Jan 8, 2022 · 3 comments · Fixed by #1052
Closed

yarn test:watch failing. Missing git/hg? #864

AmberKiso opened this issue Jan 8, 2022 · 3 comments · Fixed by #1052
Labels
documentation Improvements or additions to documentation testnet-credit Anything related to getting testnet points

Comments

@AmberKiso
Copy link
Contributor

IronFish Version 0.1.15
Windows 10 Home
Current branch is master.

Not sure if this should return an error if there's no changes...

yarn test:watch from the root, per the "Running Test" 2ii instructions in the Readme returns:

yarn run v1.22.17
$ tsc -b tsconfig.test.json && jest --watch --coverage false
Determining test suites to run...
--watch is not supported without git/hg, please use --watchAll
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Same output if I run with the 859 pull request.
@deekerno
Copy link
Contributor

Our documentation was wrong, so thanks for catching this! This issue is eligible for testnet credit, if you like!

@deekerno deekerno added documentation Improvements or additions to documentation testnet-credit Anything related to getting testnet points labels Jan 12, 2022
@AmberKiso
Copy link
Contributor Author

Claimed for all 3. Thank you!

@AmberKiso AmberKiso mentioned this issue Feb 20, 2022
Merged
@AmberKiso
Copy link
Contributor Author

Fixed by #1052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation testnet-credit Anything related to getting testnet points
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Documentation updating AmberKiso/ironfish
2 participants
@deekerno @AmberKiso