Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for golang.org/x/net/context ? #54

Open
kidoman opened this issue Aug 5, 2015 · 1 comment
Open

Support for golang.org/x/net/context ? #54

kidoman opened this issue Aug 5, 2015 · 1 comment

Comments

@kidoman
Copy link

kidoman commented Aug 5, 2015

I think there is a opportunity to fix some of the smell with the methods by letting people specify timeouts, etc. in a standard way.

Also, using this method to handle optional parameters can avoid having to create named overloads like this.

@rdallman
Copy link
Contributor

rdallman commented Aug 5, 2015

we do expose the http.Client that we are using to allow importers to change it on demand here, would this be sufficient [for you]? this would allow changing the overall http timeout, per http://golang.org/pkg/net/http/#Client . afaict, this is most customer's policy anyway (an overall client timeout) -- though I see the utility in having it on a per request basis. we gladly accept patches if you're interested in implementing that, we would want to not break the current api at the same time, which is the reason we have so many methods with optional parameters as it stands, don't want to break those precious function signatures.

thanks for feedback.

@rdallman rdallman removed their assignment Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants