You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we do expose the http.Client that we are using to allow importers to change it on demand here, would this be sufficient [for you]? this would allow changing the overall http timeout, per http://golang.org/pkg/net/http/#Client . afaict, this is most customer's policy anyway (an overall client timeout) -- though I see the utility in having it on a per request basis. we gladly accept patches if you're interested in implementing that, we would want to not break the current api at the same time, which is the reason we have so many methods with optional parameters as it stands, don't want to break those precious function signatures.
I think there is a opportunity to fix some of the smell with the methods by letting people specify timeouts, etc. in a standard way.
Also, using this method to handle optional parameters can avoid having to create named overloads like this.
The text was updated successfully, but these errors were encountered: