Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js test index.html not working #36

Closed
dpoetzsch opened this issue Jan 29, 2019 · 3 comments · Fixed by #37
Closed

js test index.html not working #36

dpoetzsch opened this issue Jan 29, 2019 · 3 comments · Fixed by #37

Comments

@dpoetzsch
Copy link

Hi,

the example core/js/src/test/index.html is broken for me. I can generate keys, but generateSymmetricKey already does not work because the function is not available in the api.

As the rest of the code depends on the symmetric key stuff, I could not test any further.

@dpoetzsch dpoetzsch changed the title js test index.html not working js test index.html not working Jan 29, 2019
@ernieturner
Copy link
Contributor

Hey @dpoetzsch,

We've done a really bad job at keeping that file up to date and usable with the current state of the library, our apologies. We really need to just remove that file at this point. The benchmark file is likely a better example of seeing how the library works. The instructions for how to hit the benchmarks are in the README and you can look at the source for examples of how all the various methods are called.

If that doesn't help or you're still confused, please let me know.

Also, we've somewhat transitioned this library from Scala to Rust which gives much greater performance than the ScalaJS library here. You might want to take a look at the WebAssembly or NodeJS repos instead if you're planning on using this in a JavaScript environment.

@dpoetzsch
Copy link
Author

Thanks for your input, I'll have a look at those repos!

I figured this one out using the benchmark.html already, maybe I could even contribute an improved index.html example -- let's see if I find time for that.

@ernieturner
Copy link
Contributor

We'd definitely appreciate it if you had time for it. We mostly moved away from it because of the dependency issues with some method arguments. For example, encrypt() requires arguments that have to come from various other methods (generatePlaintext(), generateKeyPair(), signing keys, etc) and that file somewhat needs an overhaul to really make it useful.

ernieturner pushed a commit that referenced this issue Jan 30, 2019
* Fix in-browser RecryptJS example page to be able to correctly exercise all methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants