-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] conda activate orbit using incorrect path for setup_python_env.sh #407
Comments
Upon further investigation I think the issue is with the use of I changed
It looks like SolutionI think if [ -n "$BASH_VERSION" ]; then
# Bash
SCRIPT_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
else
# Fallback for other shells
SCRIPT_DIR=$(cd "$(dirname "$0")" && pwd)
fi |
The above comment only solved the issue about activating orbit environment. Here is more complete solution: #103 (comment) |
# Description Specifies that the `--timeout` argument to `run_all_tests.py` is an int Fixes isaac-sim#407 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have run all the tests with `./orbit.sh --test` and they pass - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: AutonomousHansen <50837800+AutonomousHansen@users.noreply.github.com> Co-authored-by: jsmith-bdai <142246516+jsmith-bdai@users.noreply.github.com> Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
If you are submitting a bug report, please fill in the following details and use the tag [bug].
Describe the bug
Another issue noticed when attempting to resolve installations issue described in #406
When attempting to activate orbit environment, it fails to find
setup_python_env.sh
because it is looking in the current, Orbit repo directory instead of the_isaac_sim
symbolic linked directory where it should.Steps to reproduce
Please try to provide a minimal example to reproduce the bug. Error messages and stack traces are also helpful.
setup_conda_env.sh
Work around?
Running
conda activate orbit
from the ISAACSIM_PATH allows the script to find thesetup_python_env.sh
file; however, I don't think this should be requiredSystem Info
Describe the characteristic of your environment:
Additional context
Add any other context about the problem here.
Checklist
The text was updated successfully, but these errors were encountered: