Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] update installation #265

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TachikakaMin
Copy link

Description

When attempting to install Orbit, I encountered confusion due to the Python environment setup, which I later realized was because I use Zsh, while Orbit and Isaac Sim scripts are designed for Bash.

Type of change

  • This change requires a documentation update

Screenshots

Before:
image

After:

image

Checklist

  • I have run the pre-commit checks with ./orbit.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run all the tests with ./orbit.sh --test and they pass
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Add more description for installation since there are some differences between different bash

Signed-off-by: Yimin Tang <tangym@shanghaitech.edu.cn>
Signed-off-by: Yimin Tang <tangym@shanghaitech.edu.cn>
ADebor pushed a commit to ADebor/IsaacLab that referenced this pull request Apr 8, 2024
# Description

Quick fix for actuator config parsing.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

---------

Signed-off-by: David Hoeller <dhoeller@ethz.ch>
Co-authored-by: Mayank Mittal <mittalma@leggedrobotics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant