Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a transaction whenever a user settles up #56

Closed
IsaacCheng9 opened this issue Aug 24, 2022 · 4 comments · Fixed by #67
Closed

Create a transaction whenever a user settles up #56

IsaacCheng9 opened this issue Aug 24, 2022 · 4 comments · Fixed by #67
Assignees
Labels
enhancement New feature or request frontend Requires attention on the frontend high priority Requires immediate attention

Comments

@IsaacCheng9
Copy link
Owner

Specification

  • Currently, there is no transaction displayed when a user settles up.
    • This makes it confusing, as it can seem like the expenses don't add up.
  • To fix this, create a transaction alongside the list of expenses in the left panel.
    • For example, in the scenario below, user1 settled up £7.50, so it should have a fourth row on the left panel to reflect this.
      image
@IsaacCheng9 IsaacCheng9 added enhancement New feature or request frontend Requires attention on the frontend labels Aug 24, 2022
@IsaacCheng9 IsaacCheng9 added the high priority Requires immediate attention label Aug 30, 2022
@gkSideProjects gkSideProjects self-assigned this Aug 31, 2022
@gkSideProjects
Copy link
Collaborator

Should we store settlements in the expenses collection in mongo ? We need persistent storage for settlements in order to list them with expenses.

@IsaacCheng9
Copy link
Owner Author

Should we store settlements in the expenses collection in mongo ? We need persistent storage for settlements in order to list them with expenses.

I think it would be best to create a new collection for settlements so we have some separation, but if that complicates things heavily on the front-end then we could implement settlements as negative expenses?

@gkSideProjects
Copy link
Collaborator

It may be easier to start with negative expenses for now, if we had a separate collection for settlements the frontend would have to sort settlements and expenses together by date and time on every refresh unless we also had a transactions collection which stored both.

@IsaacCheng9
Copy link
Owner Author

It may be easier to start with negative expenses for now, if we had a separate collection for settlements the frontend would have to sort settlements and expenses together by date and time on every refresh unless we also had a transactions collection which stored both.

Let's go with this then, and rename the collection to transactions to represent this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Requires attention on the frontend high priority Requires immediate attention
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants