Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Disable pull requests while keeping issues for a repository #1191

Open
cirosantilli opened this issue Feb 22, 2018 · 9 comments
Open

Disable pull requests while keeping issues for a repository #1191

cirosantilli opened this issue Feb 22, 2018 · 9 comments

Comments

@cirosantilli
Copy link
Collaborator

cirosantilli commented Feb 22, 2018

Under settings, you can disable issues.

Also allow disabling only pull requests but not issues for projects that prefer other review mechanisms like Gerrit, but still want the GH issue tracker.

Related: dear-github/dear-github#84

Edit: reply:

Hi Ciro,Thanks for writing in! We've definitely heard some users requesting this feature over the last couple of years, and it's currently on our feature request list. I can't make any promises about if or when we may add this ability in the future, but I'll add your +1 to that feature request so the team can see it.Please let us know if there's anything else we can do for you in the meantime!All the best,Nick@nickcannariatoGitHub

@aspiers
Copy link
Collaborator

aspiers commented Mar 22, 2018

This is pretty much the standard meaningless reply from GitHub which I've seen with every feature request I've proposed - the request vanishes into their black box system and we have no clue when or even if it will ever be implemented.

For now it seems that a workaround is required. Here are a few options:

  1. Reuse OpenStack's script for auto-closing all PRs. They run it periodically from cron.
  2. Build a ProBot app to auto-close PRs (or if you can find an existing one, reuse it here and please share the link here!)
  3. Set up a pull request template which tells people not to submit PRs.

Of course you could combine the template approach with the auto-closer approach.

aspiers added a commit to aspiers/dear-github that referenced this issue Mar 22, 2018
This repository was created for a specific purpose, which was
fulfilled back in 2016.  However people are still submitting issues
about GitHub to the repository's issue tracker.  This effectively
fragments and weakens the GitHub community, because

    https://github.com/isaacs/github

was already established in 2013 for the same purpose, and has acquired
very significant momentum since then.  It is more efficient for the
community to pool its efforts in a single place, so make an issue
template which explains the current situation and encourages people
to submit issues to isaacs instead of here.

This partially addresses dear-github#207.  When combined with a PR auto-closer
bot as suggested in

    isaacs/github#1191

the combination could be considered as a full solution for dear-github#207.
@dessant
Copy link

dessant commented Jan 23, 2019

I've made a new app that immediately closes and locks new and existing issues or pull requests and also supports posting a comment and labeling. It is perfect for forks and mirrors, and you can configure it to your liking. Let me know how it works for you!

https://github.com/dessant/repo-lockdown

rivy added a commit to rivy/scoop.bucket.scoop-main that referenced this issue Dec 9, 2019
rivy added a commit to rivy/scoop.bucket.scoop-main that referenced this issue Dec 9, 2019
@phoe
Copy link

phoe commented Jan 28, 2021

See the recent discussion on Hacker News that mentions this issue: https://news.ycombinator.com/item?id=25940195

@andreynering
Copy link

One problem I see with this, is that it would prevent people to see/use patches other people made available through pull requests.

It happened to me in the past: a given bug fix or feature wasn't in master because the project was abandoned, but was available in a PR by someone that took the time to fix it. In these cases it's useful to have this code available so you can use in your own fork or patch locally.

I think it'd be better to just lock the ability of external contributors to open new pull requests, without making the existing ones unavailable, nor preventing official contributors to open new ones..

@andrewkfiedler
Copy link

One problem I see with this, is that it would prevent people to see/use patches other people made available through pull requests.

It happened to me in the past: a given bug fix or feature wasn't in master because the project was abandoned, but was available in a PR by someone that took the time to fix it. In these cases it's useful to have this code available so you can use in your own fork or patch locally.

I think it'd be better to just lock the ability of external contributors to open new pull requests, without making the existing ones unavailable, nor preventing official contributors to open new ones..

I think that case is still handled if issues are open, and the person posts a link to their fork that fixes the issue.

@untitaker

This comment has been minimized.

@nihaals
Copy link

nihaals commented Apr 3, 2021

Their roadmap repo does actually seem to have PRs restricted to collaborators.

I went to a random fork and tried to create a PR and got this:

image

Maybe they plan on opening this toggle to everyone in the future?

They also have this enabled for creating issues (without disabling them):

image

@crawfxrd
Copy link

crawfxrd commented Apr 8, 2021

@nihaals That's from "Interaction limits" in settings. But this also prevents users from making issues or even comments on issues. (Which could work for read-only mirrors on GitHub, but that's not the use case for this issue.)

@lastmjs
Copy link

lastmjs commented Jul 6, 2021

I can see the interaction limits on one of my repos. I would love to have some more granular control with interaction limits, for example in my case I want to restrict pull requests but leave issues open.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests