Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Squash merge is changing authorship of code #1750

Closed
cristiadu opened this issue Mar 5, 2020 · 5 comments
Closed

Squash merge is changing authorship of code #1750

cristiadu opened this issue Mar 5, 2020 · 5 comments

Comments

@cristiadu
Copy link

cristiadu commented Mar 5, 2020

Hi, It seems this issue started today (04 Feb 2020), but now every time a Pull-request gets merged with the SQUASH approach all the changes have their "author" changed to whoever merged the given Pull-request.

Before the behavior was to show "authored" and "commited" as two separate things, which was better as the company I work for relies on automerging of Pull-requests, and we are ending up on situations where the commit is going to have as an author the automation user, which is not ideal.

Did anything changed on Github? I wasn't able to find anything else but this: chdsbd/kodiak#300

Which seems to correlate with what I just described.

@cristiadu cristiadu changed the title Squash merge is changing ownership of code Squash merge is changing authorship of code Mar 5, 2020
@davidsiu
Copy link

davidsiu commented Mar 5, 2020

Yup, happening to us as well. Luckily it is I who is getting the credit for everyone's work. ;-P

Please Github fix this!

@Conduitry
Copy link

Well that's fairly disheartening. I get that it's hard to find The Right Answer when a PR can contain commits by any number of people, be opened by a different person, and merged by yet another different person. But I don't think that means you then go for The Consistent Answer that's wrong even more of the time.

@cristiadu
Copy link
Author

@cristiadu
Copy link
Author

Closing this as it was reverted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants