New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

502 on homepage on long streak #370

Closed
cirosantilli opened this Issue Mar 20, 2015 · 14 comments

Comments

Projects
None yet
4 participants
@cirosantilli
Collaborator

cirosantilli commented Mar 20, 2015

https://github.com/cirosantilli unicorns most of the times http://i.imgur.com/y2v7N11.png (not always) because of my huge 100 year long computationally generated streak: https://github.com/cirosantilli/test-streak

Inspired by http://stackoverflow.com/questions/20099235/who-is-the-user-with-the-longest-streak-on-github

EDIT: I have pushed a 1000 year streak later: https://github.com/cirosantilli/test-streak-1000

@cirosantilli cirosantilli changed the title from 502 on long streak to 502 on homepage on long streak Mar 20, 2015

@bwin

This comment has been minimized.

bwin commented Mar 21, 2015

😞 Why always mess with the system in the first place? (Rhetorical question, needs no answer.)
Delete the repos, see what happens. Maybe do some real work (this sounds more offensive than it's meant, but still).
I think it's safe to assume that you're the only one affected and you consciously provoked it. The rest of us (and GitHub BTW) is probably safe for the next decades...

I apologize in advance, but...
"I have a (fake) 1000-year streak on GitHub, hihi." Yay! You go, boy! Edit: 🎉 🎈 👏

Don't misinterpret my comment as me not liking you personally or whatnot, you're probably a nice guy when you're not faking commits. 😉

@bwin

This comment has been minimized.

bwin commented Mar 21, 2015

BTW since I don't know if you knew:

This is not the actual repository for the GitHub website.

Edit:

[...] But you should also email support@github.com, since this repo is strictly for our own (unofficial) tracking purposes.

@cirosantilli

This comment has been minimized.

Collaborator

cirosantilli commented Mar 21, 2015

@bwin my goals are:

  • to highlight the futility of streak metric
  • to find bugs and become famous. How many users have a 502 page 😄

They are all purely for the lolz, non important, and will likely not be furthered by my actions 😉

This is not the actual repository for the GitHub website.

Yup, I always do: #182

But I bet at least one GitHubber reads this repo.

@bwin

This comment has been minimized.

bwin commented Mar 21, 2015

😉

@NARKOZ

This comment has been minimized.

NARKOZ commented Mar 23, 2015

That's a unique way to hide your identity by slaying unicorns.

And according to Github, it isn't a bug, but feature:

The contributions graph is not designed to work when people push commits at a date in the future, which has happened in this case.

When I view the following page and hover over the highlighted square, I see "12 contributions on Jun 12, 2030".

https://github.com/kana?tab=contributions&from=2030-06-12

This indicates that the user has pushed commits using a timestamp in 2030, which is causing the issue with calculating and displaying contributions correctly. Currently we don't support this kind of commit activity in the contributions graph.

Deal with it!

@cirosantilli

This comment has been minimized.

Collaborator

cirosantilli commented Mar 23, 2015

@NARKOZ GitHub's definition of "bug" is quite strict if they don't consider 502 as bugs 😄

I could also make it 1000 years in the past if they like 😉

Can you point to where did you got the quote from just for reference? Or was it a support request that you've made?

@NARKOZ

This comment has been minimized.

NARKOZ commented Mar 23, 2015

@cirosantilli excerpt from a support ticket.

@stuartpb

This comment has been minimized.

stuartpb commented Mar 25, 2015

Assuming they calculate the streak by walking backwards from the current date, I'd say they could probably fix this by bailing out once it reaches February 29, 2008 (the date CrunchBase lists as the founding of GitHub).

@stuartpb

This comment has been minimized.

stuartpb commented Mar 25, 2015

And it definitely should be fixed. Isn't something that triggers 502 errors a vector for Denial-of-Service attacks (as it indicates that the server has crashed)?

@cirosantilli

This comment has been minimized.

Collaborator

cirosantilli commented Mar 25, 2015

@stuartpb you're a genious! I think that in the past this might haven been usable to DoS other people because commits are only considered by email and are perfectly falsifieable!

@github: sorry, I hadn't noticed that this had DoS potential against others

Right now, GitHub seems to have pushed a hotfix for that already? https://github.com/cirosantilli-puppet is maxing out at 1000 days: https://github.com/cirosantilli-puppet on a streak from 1990 to 2020 Not sure why 1000, maybe a random maximum number? Also note that there are two empty days before the green days: hovering on them does not say no activity like the others.

screenshot from 2015-03-25 09 44 51 streak missing dates

But this introduced the bug that commits in the future appear as "authored just now": GitHub shouldn't modify commit data like that, it's confusing:

screenshot from 2015-03-25 08 06 22 streak future

The real solution is to consider the timestamp of when the commit was pushed for the streak, cache things properly as they are pushed / process things asynchronously and show whatever data is in the repo on the commits.

@stuartpb

This comment has been minimized.

stuartpb commented Mar 25, 2015

@stuartpb you're a genious! I think that in the past this might haven been usable to DoS other people because commits are only considered by email and are perfectly falsifieable!

That's true, but I was thinking in terms of DDoSing all of GitHub by making every server spin and crash doing this instead of handling requests.

That's a crazy idea, though: destroy the contribution graph for any user by pushing a fake repository with fake commits. (Maybe GitHub should start only counting signed commits as contributions, for repos the user isn't marked as a contributor to?)

@stuartpb

This comment has been minimized.

stuartpb commented Mar 25, 2015

Indeed, it would appear GitHub already doesn't track contributions on repos you don't own: I just pushed 10000+ commits by cirosantilli-puppet to https://github.com/stuartpb/test-streak and they haven't moved the needle on https://github.com/cirosantilli-puppet.

@NARKOZ

This comment has been minimized.

NARKOZ commented Mar 25, 2015

The same reason why @GoogleCodeExporter's contributions don't count.

@cirosantilli

This comment has been minimized.

Collaborator

cirosantilli commented May 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment