Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Sort by the difference +1 - -1 count on issue index #600

Open
cirosantilli opened this issue Mar 11, 2016 · 18 comments
Open

Sort by the difference +1 - -1 count on issue index #600

cirosantilli opened this issue Mar 11, 2016 · 18 comments
Labels
enhancement issues parity Features that GitHub is missing, but competitors implement; also, see [Migration] reactions sorting

Comments

@cirosantilli
Copy link
Collaborator

cirosantilli commented Mar 11, 2016

Or possibly even better metrics such as the Wilson score.

Also requested at #9 but let's open an issue just for it.

Now https://github.com/blog/2119-pull-request-and-issue-reactions that we have +1 and -1 (and some other weird reactions), let us sort issues by the net (+1 count) - (-1 count) on the issue index page https://github.com/isaacs/github/issues

Update 2016-03-24: it is now possible to sort by the count of any reactions. But I want the difference between +1 and -1 totals.

GitLab did it recently, here's a screenshot PR https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2781

This is an extension of #527 to consider both up and downvotes, and deals more precisely with the current state of affairs.

Likely implies: #605

@MichaelSp
Copy link

I'm so tempted to +1 here, but I don't :D

@Mottie
Copy link

Mottie commented Mar 12, 2016

They need to also add the reaction data to the api... just the first post should be enough.

@jcrben
Copy link

jcrben commented Mar 23, 2016

Right now the way that Github is probably looking at the most requested features is to sort the list here by number of comments. So maybe we need to comment on this to push it up.

@TPS
Copy link
Collaborator

TPS commented Mar 24, 2016

@isaacs @cirosantilli @ALL This now seems to be solved (& then some — sort by any of the supplied reactions!), e.g., for this repo, to sort open issues by most 👍s:

https://github.com/isaacs/github/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc

This is fully accessible by the typical issues-list sort-menu. ☺

@cirosantilli cirosantilli changed the title Sort by +1 + -1 count on issue index Sort by +1 - -1 count on issue index Mar 24, 2016
@cirosantilli cirosantilli changed the title Sort by +1 - -1 count on issue index Sort by the difference +1 - -1 count on issue index Mar 24, 2016
@cirosantilli
Copy link
Collaborator Author

@TPS but can you sort by the difference between +1 and -1 ?

@TPS
Copy link
Collaborator

TPS commented Mar 24, 2016

@cirosantilli I though that was #605? Again, these fine differences.…

@cirosantilli
Copy link
Collaborator Author

@TPS #605 is show, this is sort. sort likely implies show though.

@TPS
Copy link
Collaborator

TPS commented Mar 24, 2016

OIC!:
#527= Bulk/gross sort
#600= Net sort
#605= Net view

Right?:bulb:

@howardroark
Copy link

If anyone is curious you can see this project's issues sorted by "thumbs up" votes here.

@cirosantilli
Copy link
Collaborator Author

@howardroark isn't that done already on GitHub: https://github.com/isaacs/github/issues?q=is:issue+is:open+sort:reactions-+1-desc ?

@TPS
Copy link
Collaborator

TPS commented Jun 17, 2016

@howardroark @cirosantilli What you folks are talking about is #527, which was solved some months ago.

@howardroark
Copy link

Thanks @TPS and @cirosantilli ! I think i'll modify the version in the link to factor in both up and down votes :)

@arshaw
Copy link

arshaw commented Jul 5, 2016

My newly released open source project, ghi-scoreboard, which is an alternate UI for Github Issues that does ranking, is meant for this sort of thing but it doesn't do this explicit feature of subtracting -1's from +1's. However, it could be easily modified to do so. If someone wants to add this feature in the code, I could give some pointers.

@TPS
Copy link
Collaborator

TPS commented Jul 5, 2016

GitLab did it recently, here's a screenshot PR https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2781

@cirosantilli Since you mentioned that, this issue could really use the Parity label!

@cirosantilli cirosantilli added the parity Features that GitHub is missing, but competitors implement; also, see [Migration] label Jul 5, 2016
@matthijsmelissen
Copy link

This issue seems to be implemented now.

@cirosantilli
Copy link
Collaborator Author

@math1985 how to use it?

@matthijsmelissen
Copy link

Sorry I misread, it is still only possible to respond by individual responses but not by difference.

@aaronfranke
Copy link

The correct way to sort content by votes is using the lower bound of Wilson score confidence interval for a Bernoulli parameter. It is an algorithm that treats a post with a high amount of total votes at a higher priority than a post with a low amount of total votes but a similar ratio of up/down votes.

Compared to subtracting votes, this avoids the problem of 200 up 100 down being sorted higher than 50 up 0 down, and compared to finding the percentage of likes to dislikes, this avoids the problem of 1 up 0 down being sorted higher than 1000 up 1 down.

@TPS TPS added the reactions label Mar 2, 2019
@TPS TPS added the sorting label Mar 20, 2019
cfritzsche added a commit to cfritzsche/cwa-wishlist that referenced this issue Jun 20, 2020
As discussed here: corona-warn-app/cwa-documentation#301 (comment)

Unfortunately an in-built sort by count(thumbs-up) minus count(thumbs-down) is not yet available: isaacs/github#600 Also the issue list can't yet display the number of thumbs-up directly: isaacs/github#605
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement issues parity Features that GitHub is missing, but competitors implement; also, see [Migration] reactions sorting
Projects
None yet
Development

No branches or pull requests

9 participants