Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 18.15.0 compatibility? #11

Closed
JustinGrote opened this issue Oct 11, 2023 · 3 comments
Closed

Node 18.15.0 compatibility? #11

JustinGrote opened this issue Oct 11, 2023 · 3 comments

Comments

@JustinGrote
Copy link

Is there a specific reason why 18.16 is specified as the minimum? 18.15 is the current node version for Electron 25 (and subsequently Visual Studio Code aka vscode) and so I'm getting an error in trying to use node-tap to test a vscode extension.
@isaacs isaacs closed this as completed in 75999cf Oct 11, 2023
@isaacs
Copy link
Owner

isaacs commented Oct 11, 2023

Yeah, idk why I picked 18.16 tbh. Might have been using something added then? Whatever the case 18.15 passes CI, so I'll just loosen it. In the meantime, feel free to just force it if you want, it's working fine.

@JustinGrote
Copy link
Author

@isaacs thanks!

@isaacs
Copy link
Owner

isaacs commented Oct 11, 2023

Landed on 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@isaacs @JustinGrote