Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Above Controller #32

Closed
Bluesky13503 opened this issue Jan 4, 2018 · 15 comments
Closed

Above Controller #32

Bluesky13503 opened this issue Jan 4, 2018 · 15 comments

Comments

@Bluesky13503
Copy link

I find it confusing for people to use it.
The Issue is, that a Notification is displayed onto of the current Content.
This should be a Subview in Navigationbar and pushes the content further down.

If you have a scroll list with Large Title and start to scroll the Large title becomes small and the notification is stuck in the upper part of the screen.

Wasn't able to solve it myself :(

@isadon
Copy link
Owner

isadon commented Jan 4, 2018

When you say stuck do you mean that you want the notification to scroll up with the scroll list? As far as how RMessage is presented remember originally it began as a fork of TSMessages so thats why its presented the way it is. There may or may not be better ways to do the presentation each with pros/cons. I can definitely look into possible different presentation methods for the future.

Can you post a gif or something that allows me to see the problem?

@Bluesky13503
Copy link
Author

Do you have an email address i can send it to?

@isadon
Copy link
Owner

isadon commented Jan 4, 2018

I think github allows you to add the files here.

@Bluesky13503
Copy link
Author

I did a video right of the phone ;) that’s why! I can’t a a video here ;(

@isadon
Copy link
Owner

isadon commented Jan 4, 2018

Oh :). Unfortunately I can't provide a personal email address. Simply upload the video to some public video service and post a link here so that I may see.

@isadon
Copy link
Owner

isadon commented Jan 4, 2018

So can you describe in good detail the actual problem? What is it that occurs exactly?

@Bluesky13503
Copy link
Author

Check this out

7b7f7421-0af1-4c7b-93ea-28ee0c3857b4

@Bluesky13503
Copy link
Author

Well you have large title from iOS 11 enabled, then notification kicks in, the user start scrolling!
Then this happens.

@Bluesky13503
Copy link
Author

@isadon
Copy link
Owner

isadon commented Jan 4, 2018

Ok yea. I see it. As far as how it presents before the scrolling is that a navigation bar up where the title is? In other words the view right above the notification is a navigation bar? If it is then I'm assuming the initial presentation of the notification is correct as its supposed to present under the nav bar. The position after scrolling would be the issue. If my assumptions are correct about your issue why not simply programmatically call to dismiss the notification as soon as a scroll occurs by the user?

@Bluesky13503
Copy link
Author

Well, yes the issue is about the behavior when you start scrolling. Well dismissing the notification is a solution. But what happens if the user starts scrolling immediately?
This would be no good user experience.
Better would be the the notification would be part of the navigation bar itself.

@isadon
Copy link
Owner

isadon commented Jan 4, 2018

Hmm. I will look further into this.

@isadon
Copy link
Owner

isadon commented Jan 7, 2018

Can you pull the pin_to_navbar branch and tell me if it resolves this issue for you?

@Bluesky13503
Copy link
Author

Problem Solved with "Pin_to_NavBar" :)

@isadon
Copy link
Owner

isadon commented Jan 9, 2018

Thanks for the bug report. You can go ahead and use develop now as that feature branch will be deleted.

@isadon isadon closed this as completed Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants