Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplementation JSONHelper with the magic of Generics #37

Closed
lancy opened this issue May 15, 2015 · 5 comments · Fixed by #39
Closed

Reimplementation JSONHelper with the magic of Generics #37

lancy opened this issue May 15, 2015 · 5 comments · Fixed by #39
Assignees
Milestone

Comments

@lancy
Copy link

lancy commented May 15, 2015

Hey.

I noticed that there are so many repeating code in JSONHelper, so I just reimplement most of it.
I try to use generics as much as I can to simplify the code, and now I make a little success.
With less then half the origin code, it can do the same things as before, even more features were added.
https://github.com/lancy/JSONHelper
It's compatible to most of the origin APIs, not all of them, but If you like it, I will make a pull request.

By the way, hope you don't mind that I'm planning to create another individual JSON Library to add more features (something like serialization), and It may refer some of your code. I will make a statements to thanks you and this project.

Have fun!

┆Issue is synchronized with this Asana task

@mabedan
Copy link
Contributor

mabedan commented May 15, 2015

haven't had a deep look yet, but it seems very good

@isair
Copy link
Owner

isair commented May 15, 2015

Hi lancy,

First of all, thanks for taking the time to improve this library. JSONHelper is a library that was started back in the early days of Xcode6-Beta6. The Swift compiler had a very hard time with smart attempts at type conversion and package managers didn't support Swift libraries yet. Therefore, JSONHelper turned out to be a library with lots of repeating code in a single file. I haven't been able to do much other than accept pull requests recently due to my work demanding more and more every day, and I have been wanting to make the code DRY for a long while now. I will check your code in detail this weekend but I like what I see so far. You are welcome to do anything the license permits, which includes altering and redistributing it as long as you mark it as such. However, I'd personally appreciate contributing back to the project more as serialization is also a planned feature for this library (as I have written to you here).

@isair
Copy link
Owner

isair commented May 23, 2015

@lancy I have checked your branch in detail, ran the tests, and would love to see a pull request from it so I can go ahead and make it fully backwards compatible then start building the rest of the queued enhancements on top of it.

@lancy
Copy link
Author

lancy commented May 23, 2015

@isair i just created a pull request, check it out :)
btw, Travis CI is not compatible to Swift 1.2, you could use Circle CI https://circleci.com

@isair
Copy link
Owner

isair commented May 25, 2015

Thanks for your contribution! A couple of my private projects are using Circle CI and last I checked they still hadn't added Swift 1.2 support. Will check again.

@isair isair added in progress and removed ready labels May 29, 2015
@isair isair mentioned this issue Jun 14, 2015
@isair isair self-assigned this Jun 14, 2015
@isair isair added this to the 2.0.0 milestone Jun 15, 2015
@isair isair removed the in progress label Nov 23, 2015
@isair isair closed this as completed in #39 Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants