Skip to content

Commit

Permalink
fix issue YahooArchive#496 package.json/engines.node:">.4",npm:">1.0"
Browse files Browse the repository at this point in the history
  • Loading branch information
Isao Yagi committed Sep 13, 2012
1 parent e1359c6 commit 43cd1e4
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@
"mojito": "bin/mojito"
},
"engines": {
"node": ">= 0.4.0 < 0.7.0",
"npm": ">= 1.0.0"
"node": ">0.4",
"npm": ">1.0"
},
"devDependencies": {
"node-static": "~0.6.1",
Expand All @@ -62,10 +62,6 @@
"test": "./tests/run.js test -u --group server --driver nodejs && ./tests/run.js test -u --group client --driver selenium"
},
"yahoo": {
"bugzilla": {
"product": "Mojito",
"component": "General"
},
"mojito": {
"type": "bundle",
"location": "lib/app"
Expand Down

3 comments on commit 43cd1e4

@rwaldura
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that seems to be a bit more than what I was requesting...
Does this say Mojito isn't compatible with Node 4.x, or NPM 1.x?

@isao
Copy link
Owner

@isao isao commented on 43cd1e4 Sep 13, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, it says any node greater than 0.4 and npm greater than 1.0, but not including these exact versions.

do you want me to update to >=? However, I think a scenario where the patch version is zero and a benefit of any kind is unlikely.

@rwaldura
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To summarize our chat: we want to declare Mojito compatible will all versions of Node, starting with Node 0.4.x
Same for NPM 1.x.
Where 'x' is the latest version.

Please sign in to comment.