Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HiveInterface missing 'path' parameter for boxExists & deleteBoxFromDisk #742

Open
wbusey0 opened this issue Jul 28, 2021 · 1 comment
Open

Comments

@wbusey0
Copy link
Contributor

wbusey0 commented Jul 28, 2021

Both boxExists and deleteBoxFromDisk have an optional named path parameter in HiveImpl:

  Future<void> deleteBoxFromDisk(String name, {String? path}) async {
    //...
  }
  Future<bool> boxExists(String name, {String? path}) async {
    //..
  }

However, HiveInterface does not contain these parameter and as such they cannot be used:

  Future<void> deleteBoxFromDisk(String name);
  Future<bool> boxExists(String name);

https://github.com/hivedb/hive/blob/413ae3594f7142eb8b4b428f60c5c090d12d0799/hive/lib/src/hive.dart#L54

@wbusey0
Copy link
Contributor Author

wbusey0 commented Jul 28, 2021

Should be a small non-breaking change as the implementation is already correct. I can create a PR if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant