Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tetradic Palette 🎨 #21

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

tavyandy97
Copy link
Contributor

Raising a PR for the issue that I raised earlier - #20

Description

Matercolors had the support for analogous and triadic colors. I thought supporting tetradic color schemes(shown in the image below) would be a good addition.

image

Tetradic Colors

  1. The first tetradic is obtained by rotating the color by 60 degrees in the wheel [primary]
  2. The second tetradic is obtained by rotating the color by 180 degrees in the wheel [secondary]
  3. The third tetradic is obtained by rotating the color by 240 degrees/-120 degrees in the wheel [tertiary]

@tavyandy97
Copy link
Contributor Author

Hey @isarvindone
Wanted to bump the above PR up 😄 Lemme know whenever you get time to review it, and if it requires any changes

Copy link
Owner

@arvindcheenu arvindcheenu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for your contribution!

@@ -64,6 +71,21 @@ export default class Matercolor {
triadicObject.primary = this.makePalette('firstTriadic', true)
triadicObject.secondary = this.makePalette('secondTriadic', true)
return triadicObject
} else if (paletteName === 'firstTetradic') {
Prefix = 'Q1'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! "Q" for "Quad" I presume?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it!

@arvindcheenu arvindcheenu merged commit 5b9eb1d into arvindcheenu:main Sep 22, 2023
@tavyandy97
Copy link
Contributor Author

Thanks a lot for taking the time out @isarvindone ! 🥳 Feel free to publish a version whenever you want

@arvindcheenu
Copy link
Owner

Hey @isarvindone

Wanted to bump the above PR up 😄 Lemme know whenever you get time to review it, and if it requires any changes

Hey @tavyandy97

I apologize for the delay. Was quite busy with CHI paper submissions and PhD applications. I merged the branch. Will package it into a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants