Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's get rid of some unnecessary bytes #95

Closed
wants to merge 2 commits into from
Closed

Let's get rid of some unnecessary bytes #95

wants to merge 2 commits into from

Conversation

arthurvr
Copy link

2 little things updated:

  • The browser will automatically find the favicon if it's in root. No need to include a <link>.
  • A link to the humans.txt in your html file isn't needed. It will automatically check the root.

@konklone
Copy link
Member

I really appreciate the contribution! But there are issues with both of these:

  • I had intended to update to a larger, non-default icon and URL. I just did that, so I do need to spell out the favicon by default.
  • I link to the humans.txt file so that other humans will notice it in the source and browse there. It's not meant for automatic crawlers. (Are there any automatic crawlers for /humans.txt...?)

But thank you again for hacking on this! More PRs very welcome. 😺

@konklone konklone closed this Dec 25, 2014
@arthurvr
Copy link
Author

I had intended to update to a larger, non-default icon and URL. I just did that, so I do need to spell out the favicon by default.

Just FYI, but your favicon shouldn't be bigger than 32px. You can always include touch icons, w8 tiles, ... but that isn't the link tag we're talking about.

I link to the humans.txt file so that other humans will notice it in the source and browse there. It's not meant for automatic crawlers. (Are there any automatic crawlers for /humans.txt...?)

There aren't any automatic crawlers, and that's exactly why you shouldn't include the unnecessary bytes of a <link>. People that are searching for that file know where to find it. As seen in many boilerplates/generators, this just isn't needed. Checkout, for example: h5bp/html5-boilerplate#289 and h5bp/html5-boilerplate#1342.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants