Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleFill() returns an error when the input is a complete dataframe #52

Closed
drkarthi opened this issue Feb 19, 2018 · 2 comments
Closed

Comments

@drkarthi
Copy link
Contributor

This can be a problem if you want to fill missing values for multiple data frames and if some of them turn out to be already complete (have to add an extra check). Returning a warning may be a better option.

@sergeyf
Copy link
Collaborator

sergeyf commented Jul 27, 2018

Good idea. Any interest in a PR that does this?

@drkarthi
Copy link
Contributor Author

drkarthi commented Jul 31, 2018

Sure, I can make one.

@sergeyf sergeyf closed this as completed Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants