Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautify function names #20

Closed
qianyizh opened this issue May 10, 2017 · 0 comments
Closed

Beautify function names #20

qianyizh opened this issue May 10, 2017 · 0 comments
Assignees

Comments

@qianyizh
Copy link
Collaborator

Things like:

  • SelectionPolygonVolume::CropGeometry
  • SelectDownSample, VoxelDownSample, UniformDownSample, ...
  • ComputePointCloudToPointCloudDistance, ...

Move the output to the return part of functions. For all Geometry type, return std::share_ptr because Visualizer needs to share the ownership. But for std::vector, use the move and trivial copy mechanics to directly return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant