Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom principal point #78

Closed
syncle opened this issue Sep 11, 2017 · 1 comment
Closed

Custom principal point #78

syncle opened this issue Sep 11, 2017 · 1 comment

Comments

@syncle
Copy link
Contributor

syncle commented Sep 11, 2017

ConvertFromPinholeCameraParameters function in Open3D/src/Visualization/Visualizer/ViewControl.cpp is designed for deterministic pinhole camera model: its principal point should be central position of an image domain.

For example, ViewGeometry terminates if below condition does not meet:

intrinsic.intrinsic_matrix_(0, 2) != (double)window_width_ / 2.0 - 0.5 ||
intrinsic.intrinsic_matrix_(1, 2) != (double)window_height_ / 2.0 - 0.5)

Can we extend current OpenGL interface to allow principle point of non-centered position?

@qianyizh
Copy link
Collaborator

No. Because this is OpenGL behavior.
If you render using OpenGL, the captured image has principle point (w/2-0.5, h/2-0.5).

We need to add different rendering shaders if we are to remove this sanity check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants