feat(parental-leave): Implement rights code util #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…tation with primary parent
baering
commented
Jun 9, 2021
| @@ -208,7 +254,7 @@ export const transformApplicationToParentalLeaveDTO = ( | |||
| // TODO: refactor period.endDate to not include time | |||
| to: period.endDate.split('T')[0], | |||
| ratio: Number(period.ratio), | |||
| approved: true, | |||
| approved: false, | |||
There was a problem hiding this comment.
At one point we thought this meant approved by employer, but this is updated by VMST when they have approved it.
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
addi
added a commit
that referenced
this pull request
Jun 10, 2021
* main: Allow pull requests to be prioritized feat: ReadSpeaker webreader on articles (#4132) fix(api-domains-endorsement-system): Open endorsement list not working (#4156) Revert "fix(tests): Run tests as current user (#4152)" feat(party-letter): Bulk upload (#4098) fix(tests): Run tests as current user (#4152) feat(party-application): Bulk upload in party application (#4092) feat(judicial-system): InvestigationRequest Prosecutors (#4023) feat(parental-leave): Implement rights code util (#4103) fix: add correct License type (#4145) chore(core): Update dockerfile node versions from 14.16 to 14.17 (#4147) chore(gjafakort): Update heading text for "Ferðagjöfin þín" (#4141) chore: Remove package-lock.json (#4142) feat(judicial-system): Change placeholder text is appeal date pickers on SignedVerdictOverview page (#4139)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://app.asana.com/0/1182378413629561/1200340152240431
Implements basic rights code for unborn children.
Primary parents get either
M-S-GR(mother-self_employed-basic_rights) orM-L-GR(mother-employed-basic_rights).Secondary parents without custody get either
FO-FL-L-GR(parent-without_custody-salary-basic_rights) orFO-FL-S-GR(parent-without_custody-self_employed-basic_rights), if they are in registered cohabitation with primary parent then they receive custody automatically and thenFL-(without custody) is not in the code.Rights code for born children will be implemented in another PR.
Why
So that the reviewer of the application is aware of what rights the applicant has.
Screenshots
Also updated how error messages are displayed, if the message is a JSON string and contains
messagethen it is used (TODO translate API errors)Checklist: