-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parental-leave): Implement rights code util #4103
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…tation with primary parent
@@ -208,7 +254,7 @@ export const transformApplicationToParentalLeaveDTO = ( | |||
// TODO: refactor period.endDate to not include time | |||
to: period.endDate.split('T')[0], | |||
ratio: Number(period.ratio), | |||
approved: true, | |||
approved: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At one point we thought this meant approved by employer, but this is updated by VMST when they have approved it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This PR currently has a merge conflict. Please resolve this and then re-add the |
* main: Allow pull requests to be prioritized feat: ReadSpeaker webreader on articles (#4132) fix(api-domains-endorsement-system): Open endorsement list not working (#4156) Revert "fix(tests): Run tests as current user (#4152)" feat(party-letter): Bulk upload (#4098) fix(tests): Run tests as current user (#4152) feat(party-application): Bulk upload in party application (#4092) feat(judicial-system): InvestigationRequest Prosecutors (#4023) feat(parental-leave): Implement rights code util (#4103) fix: add correct License type (#4145) chore(core): Update dockerfile node versions from 14.16 to 14.17 (#4147) chore(gjafakort): Update heading text for "Ferðagjöfin þín" (#4141) chore: Remove package-lock.json (#4142) feat(judicial-system): Change placeholder text is appeal date pickers on SignedVerdictOverview page (#4139)
What
https://app.asana.com/0/1182378413629561/1200340152240431
Implements basic rights code for unborn children.
Primary parents get either
M-S-GR
(mother-self_employed-basic_rights) orM-L-GR
(mother-employed-basic_rights).Secondary parents without custody get either
FO-FL-L-GR
(parent-without_custody-salary-basic_rights) orFO-FL-S-GR
(parent-without_custody-self_employed-basic_rights), if they are in registered cohabitation with primary parent then they receive custody automatically and thenFL-
(without custody) is not in the code.Rights code for born children will be implemented in another PR.
Why
So that the reviewer of the application is aware of what rights the applicant has.
Screenshots
Also updated how error messages are displayed, if the message is a JSON string and contains
message
then it is used (TODO translate API errors)Checklist: