Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isConstituentOf is missing from list of Islandora RELS-EXT predicates #40

Closed
mjordan opened this issue Jul 6, 2015 · 6 comments
Closed

Comments

@mjordan
Copy link
Contributor

mjordan commented Jul 6, 2015

The compound object solution pack adds an 'isConstituentOf' relationship to child objects' RELS-EXT. This should be listed on the Islandora namespace RELS-EXT predicates page. I can open a PR - let me know.

@DiegoPino
Copy link
Contributor

Hi @mjordan, isConstituentOf is part of of the fedora ontology. So i my opinion should not be included,
but thanks to your issue, i found also predicates used by islandora_object_lock_module are missing.
Copy-pasta from the module:
define('ISLANDORA_OBJECT_LOCK_EXPIRY_PRED', 'lock-expiry');
define('ISLANDORA_OBJECT_LOCK_USER_PRED', 'locked-by');
define('ISLANDORA_OBJECT_LOCK_IS_MANAGEMENT_RULE_PRED', 'isManagementRule');
define('ISLANDORA_OBJECT_LOCK_IS_USER_MANAGEMENT_RULE_PRED', 'isUserManagementRule');

Thanks!

@ruebot
Copy link
Member

ruebot commented Jul 8, 2015

I should be ignoring this since I'm on vacation...

But, @DiegoPino is correct w/r/t to isConstituentOf. It is documented here.

The Islandora Object Lock predicates are not included in the documentation, because Islandora Object Lock is not an Islandora Foundation module, and therefore not apart of any official release.

@DiegoPino
Copy link
Contributor

You should ignore us completely @ruebot, and you are right as always. But, Com'on, just unplug your devices and take a well deserved rest!
Thanks for checking in. Take care.-

@mjordan
Copy link
Contributor Author

mjordan commented Jul 8, 2015

OK, fair enough, I didn't check the Fedora predicates list before posting. But where does Object Lock come into play? On the Fedora predicates page isConstituentOf is listed under Compound.

@mjordan
Copy link
Contributor Author

mjordan commented Jul 8, 2015

And @ruebot don't reply on your well-deserved vacay....

@ruebot
Copy link
Member

ruebot commented Jul 11, 2015

That page is constructed from the grep command listed at the top. That command was run against the 7.x-1.5 code base. I pulled the output of that command into the modules that use a particular predicate. Hence isConstituentOf being listed under Compound.

@ruebot ruebot closed this as completed Jul 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants