Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularization for beta v2 #220

Merged
merged 50 commits into from Sep 2, 2019
Merged

Modularization for beta v2 #220

merged 50 commits into from Sep 2, 2019

Conversation

SimonSAMPERE
Copy link
Collaborator

see #180

SimonSAMPERE and others added 30 commits July 9, 2019 15:33
@SimonSAMPERE
Searching by keywords module with PyQt
8ecab0e 
close #194
@Guts
minor fixes
56e6ed4
@Guts
set placeholder as disabled
db4c16d
@SimonSAMPERE
correcting and typo
e685f01
@SimonSAMPERE
finishing + typo
06dd59d 
close #194
@Guts
Merge pull request #206 from isogeo/new_keywords_search
c94c556 
PyQt Checkable Combobox for keywords selection
@Guts
upgrade pipfiles
b13239e
@SimonSAMPERE
add_layer - code modularization
5989d6b 
#178
layers can be added from files or services (OGC and ESRI)
@SimonSAMPERE
filling 'Layer's Properties' with basic infos
4724ed3 
#178
work also for services
@SimonSAMPERE
cleaning isogeo.py
fb3b292 
#178
@SimonSAMPERE
creating 'metadata_sync.py' module and using it in 'add_layer.py' module
1f66321 
#209
@SimonSAMPERE
creating 'quick_search.py' module and using it in 'isogeo.py'
81ca246 
#176

The most of the quicksearch managment is out of isogeo.py
@SimonSAMPERE
cleaning
0bb0ac1
@SimonSAMPERE
Merge pull request #211 from isogeo/dev_modularization
492bb93 
Modularization 1 - add layers, metadata synchronization, make quick searches
@SimonSAMPERE
creating results/cache.py and results/display.py modules
f25e18c 
#179
splitting old modules/results.py into new modules modules/results/cache.py and modules/results/display.py
using modules/results/cache.py into modules/results/display.py and modules/results/display.py  into isogeo.py
@SimonSAMPERE
moving build_postgis_dict() method to modules/results/display.py
2e77b1d 
#178
@SimonSAMPERE
testing modules/results/cache.py module
2ce825e 
#179
@SimonSAMPERE
Merge pull request #212 from isogeo/dev_modularization
3abd19d 
Modularization 2 - manage layer adding cache
@SimonSAMPERE
creating api/auth.py and api/request.py modules
d4d8e9e 
#177

removing old `api.py` and adapting `__init__.py` files of `modules` folder
@SimonSAMPERE
integration of api/request.py and api/auth.py in the existing ope…
ac9d387 
…ration

#177

replacing old IsogeoPlgApiMngr with new Authenticator or ApiRequester
introducing ApiRequester in Isogeo by signal and slot system
+ cleaning Isogeo
@SimonSAMPERE
Renaming for trad
98c4112 
#177

adapting traduction to the renaming of the old IsogeoPlgApiMngr
@SimonSAMPERE
minor adjustments
a5518a4
@SimonSAMPERE
unsuccessful first steps to test new api/auth.py and `api/request.p…
bacc6f9 
…y` modules

#177
@SimonSAMPERE
cleaning
4e78a6c
@Guts
Merge pull request #213 from isogeo/dev_modularization
b3ebd93 
Modularization 3 - interaction with the API
@SimonSAMPERE
creating modules/api/shares.py module
8af616a 
#177 #215
@SimonSAMPERE
typo
93bab5a
@SimonSAMPERE
Improving modules/api/request.py operation
4c87ace 
#215
#177
Complete reorganization of the code to allow to send shares request to Isogeo's API asynchronously
@SimonSAMPERE
quick correction
2e5c7e8 
#176
@SimonSAMPERE
adapting isogeo.py
345ac88 
#177 #215
Adapting Isogeo main class to new signals and slots system of ApiRequester
Guts and others added 19 commits August 23, 2019 14:32
@Guts
Displaying shares informations - Merge #216
7929a76 
Modularization 4 - Displaying shares informations
@SimonSAMPERE
from os.path to pathlib.Path
235403d 
#214
@SimonSAMPERE
from os.path to pathlib.Path
a5da8ca 
#214
@SimonSAMPERE
creating search_form.py
0b0a577 
#210
@SimonSAMPERE
changing default search's parameters format
836131e
@SimonSAMPERE
make search_form.py functional
15d311c 
#210
@SimonSAMPERE
ajust request.py module
7638241 
#210
- adding the get_tags method remove from auth.py module
- correcting the get_tags method to match the fields names with the parameters names
- ajusting search_sig and details_sig signals to make them pass tags as dicts to their slot
@SimonSAMPERE
typo
23a38ea
@SimonSAMPERE
Update metatdata_display.py module
9253fd3 
#210
adapt it to the adjustment of the requester.py's signals
@SimonSAMPERE
update cache.py
eeb8ea0 
#214
@SimonSAMPERE
integrate serahc_form.py module
32b3aaa 
#214
#210

into quicksearch managment and results display
@SimonSAMPERE
intergate search_form.py into isogeo.py
e1244c1 
#214
#210
- docstring
- intergate SearchFormManager use in the script
- major change in the way search work to make the search form modularization easier and simplify operation
- remove methods that are no longer useful or that now belong to the search_form.py module
@SimonSAMPERE
house keeping
ad6b435
@SimonSAMPERE
moving ResultsManager use from isogeo.py to search_form.py
bddfcc2 
#210
+ docstring
@SimonSAMPERE
investigate
00b7f50 
#219
@SimonSAMPERE
typo
1166511
@SimonSAMPERE
house keeping
f187fbb
@SimonSAMPERE
first try formatting
334134b 
#218
@SimonSAMPERE
Management of the search form - Merge pull request #217
628b104 
Remove the management of the search form from the main class **Isogeo** (`isogeo.py`)
see #217 for more details about code changes and improvements
@SimonSAMPERE SimonSAMPERE added enhancement Amélioration du fonctionnement existant code art Qualité du code source PyQGIS labels Sep 2, 2019
@SimonSAMPERE SimonSAMPERE self-assigned this Sep 2, 2019
@SimonSAMPERE SimonSAMPERE added this to In progress in Modularisation via automation Sep 2, 2019
Modularisation automation moved this from In progress to Reviewer approved Sep 2, 2019
@SimonSAMPERE SimonSAMPERE merged commit 17bd2ee into master Sep 2, 2019
Modularisation automation moved this from Reviewer approved to Done Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guts Guts Guts approved these changes

Assignees

@SimonSAMPERE SimonSAMPERE

Labels
code art Qualité du code source enhancement Amélioration du fonctionnement existant
Projects
No open projects
Modularisation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonSAMPERE @Guts