Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page title does not take skipped steps into account #2006

Closed
fritzmg opened this issue Jan 8, 2019 · 0 comments
Closed

page title does not take skipped steps into account #2006

fritzmg opened this issue Jan 8, 2019 · 0 comments
Labels
Milestone

Comments

@fritzmg
Copy link
Contributor

fritzmg commented Jan 8, 2019

Let's say you enabled the option to skip the shipping method step in the checkout, if only one shipping method is available. When you start the checkout process on the billing & shipping address step, the page title will say "Step 1 of 4" instead of "Step 1 of 3". Of course this is to be expected, since the number of available shipping methods can vary depending on the address.

However, when you then go to the next step and the shipping method is skipped, the page title will suddenly say "Step 3 of 4" - even though only 3 steps are shown:

<div class="steps block">
  <ol class="level_1 steps3">
    <li class="address passed first"></li>
    <li class="payment active"></li>
    <li class="review last"></li>
  </ol>
</div>

Imho it would be better if it would say "Step 2 of 3" at that point.

Also a nice to have would be, if the shop configuration only ever allows for only one shipping method, that the initial step also shows "Step 1 of 3" instead of "Step 1 of 4".

@aschempp aschempp added the bug label Jan 8, 2019
@aschempp aschempp added this to the 2.5.10 milestone Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants