Use getClassForModelType to build the new surcharge instead of "new static()"

[rhymeadam]

I was trying to create a custom "rule" surcharge that extends the one in isotope_rules. I registered my class as the "rule" model type in config.php but when this line runs on the front end, TypeAgent throws an exception in the constructor because it can't find Isotope\Model\ProductCollectionSurcharge\Rule in the static $arrModelTypes array. I believe this would be easily solved if the code at this line used getClassForModelType method to see what class is set as the "rule" model type first.

core/system/modules/isotope_rules/library/Isotope/Model/ProductCollectionSurcharge/Rule.php

Line 60 in 7f81e8b

$objSurcharge = new static();

[aschempp]

I don't think replacing the model class is a supported use case … what are you trying to do?

[rhymeadam]

I wanted to extend the Isotope\Model\ProductCollectionSurcharge\Rule methods to implement my own logic for specific product classes. I figured changing line 60 to this would work, and most likely not break anything down the line, or am I mistaken?

        $strClass = static::getClassForModelType('rule');
        $objSurcharge = new $strClass();

[aschempp]

It would probably be better to implement your own calculatePrice hook instead, since that's the supported "gateway".

[aschempp]

just looking at this again, wouldn't this use your new class if yours is extending the Isotope rule class?