Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate default variant url without parameters #2403

Open
cboelter opened this issue Jan 20, 2023 · 1 comment
Open

Generate default variant url without parameters #2403

cboelter opened this issue Jan 20, 2023 · 1 comment

Comments

@cboelter
Copy link
Contributor

During the debugging of #2402 I thought a bit about the url generation. In case the current product is the default variant it should be possible to generate a product url without the query parameters. The default variant is still loaded without the parameters. The main benefit of this change would that we have cleaner product url's in the sitemap.xml.

What do you think about that?

@aschempp
Copy link
Member

sound reasonable, but not sure if that's worth the effort since only a robot will look at the sitemap.xml? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants