Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interrupt state #14

Closed
wants to merge 2 commits into from
Closed

Conversation

orikuma
Copy link
Contributor

@orikuma orikuma commented Apr 3, 2024

I want to stop executing multi-contact motion after finishing MCC::ConfigMotion state, but MCC::Initial resets the managers and tasks in MultiContactController and they may cause inconsistency in the motion without interrupts.
Therefore, I implemented MCC::Interrupt that only stops execution of multi-contact motion without reset.

Copy link
Member

@mmurooka mmurooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I added some small comments.

@@ -0,0 +1,33 @@
#pragma once

#include <TrajColl/CubicInterpolator.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary.

Copy link
Contributor Author

@orikuma orikuma Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f401697

}

// Setup GUI
ctl().gui()->addElement({ctl().name()}, mc_rtc::gui::Button("Start", [this]() { phase_ = 1; }));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Resume" is a good name for the button in the Interrupt state. (and we can distinguishes the buttons between Initial state and Interrupt state)

Copy link
Contributor Author

@orikuma orikuma Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in f401697

orikuma added a commit to orikuma/MultiContactController that referenced this pull request Apr 12, 2024
orikuma added a commit to orikuma/MultiContactController that referenced this pull request Apr 12, 2024
@mmurooka mmurooka closed this in #16 Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants