-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[admin]: Trailing slash in public-endpoint (was: 404 on admin page) #498
Comments
Note that public-endpoint doesn't determine where the admin page gets served, it's just used when isso redirects to itself. |
OK, what else should I be checking? |
Does isso itself work on the URL that you're trying to access the admin page on?
What version of isso are you running?
…On November 14, 2018 8:14:06 PM UTC, Stanislas ***@***.***> wrote:
OK, what else should I be checking?
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#498 (comment)
|
Yes it's still working great, it's been running for months on my blog. I've upgraded to the latest version so |
Do you mean 0.11.1 ? There is no 1.11.1 release. |
Oops, yes, 0.11.1 |
I have a different issue: I can access the admin interface (no 404 error) but when I type the password (the one set in the conf file) I am still on the login page. Same version as @angristan and no other issues (comments are showing fine on my Ghost posts). |
@frenchvandal what does the Network panel tells you when you try to log in? (F12 → click on network to access this panel) |
Adding: [admin]
enabled = true
password = xxxx While keeping [generic]
admin_password = xxxxx I get
But I don't have a 404 anymore: I read in #506 that
I'm confused 🤷♂️ |
@blatinier thanks to @angristan I did what was said in #506 (in the conf, removed password from [admin] , added admin_password in [general]). |
Removing the trailing |
isso should probably either
|
Relevant: #519, but this truncation should also be applied more widely |
See https://werkzeug.palletsprojects.com/en/2.1.x/routing/#werkzeug.routing.Rule `strict_slashes=False` means both `/new` and `/new/` are accepted as route endpoints. Contributes to isso-comments#498
See https://werkzeug.palletsprojects.com/en/2.1.x/routing/#werkzeug.routing.Rule `strict_slashes=False` means both `/new` and `/new/` are accepted as route endpoints. Contributes to isso-comments#498
``` /admin -> /admin/ /login -> /login/ ``` Since any non-API page can reasonably be expected to end in a trailing slash by visitors (it is a path, not a file), set the trailing slash version as canonical. This has another positive side-effect: Visiting `isso.dev/admin` (without trailing slash) will redirect to `/admin/` automatically, thus obviating issues like isso-comments#489 [^1]. Any Javascript or CSS files are not affected as they are served throught the `SharedDataMiddleware` in `__init__.py`` anyway. [^1]: isso-comments#498
I am running 0.11.1, and I get this error on my admin page:
I try to access
https://my-isso.tld/admin/
. I haveadmin_password
andpublic-endpoint
set in my config.The text was updated successfully, but these errors were encountered: