Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage reportDir should respect --cwd #764

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Conversation

jl-
Copy link
Contributor

@jl- jl- commented Jan 17, 2018

when invoked with nyc --cwd sub-directory, coverage reports were saved in ./coverage, shouldn't it be ./sub-directory/coverage?

when invoked with `nyc --cwd sub-directory`, coverage reports were saved in `./coverage`, shouldn't it be `./sub-directory/coverage`?
@coveralls
Copy link

coveralls commented Jan 17, 2018

Coverage Status

Changes Unknown when pulling 3f85c62 on jl-:patch-1 into ** on istanbuljs:master**.

Copy link
Member

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me, but I don't think we have an existing test case for it. That would be great to add, but thanks for the contribution :)

@bcoe
Copy link
Member

bcoe commented Jan 22, 2018

@jl- this seems reasonable to me; :shipit:

@bcoe bcoe merged commit b0d6dae into istanbuljs:master Jan 22, 2018
@bcoe
Copy link
Member

bcoe commented Feb 13, 2018

@jl- please try npm i nyc@next, this candidate release should have your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants