Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CRDs are broken in 1.24.x #287

Closed
tibers opened this issue Apr 10, 2023 · 4 comments
Closed

[BUG] CRDs are broken in 1.24.x #287

tibers opened this issue Apr 10, 2023 · 4 comments
Labels
bug Something isn't working hacktoberfest issue open for hackoberfest contribution help wanted Extra attention is needed

Comments

@tibers
Copy link

tibers commented Apr 10, 2023

Describe the bug
CRDs are broken in k8s version 1.24.x

Steps To Reproduce
Attempt to install admiral. At the step $ADMIRAL_HOME/scripts/install_admiral.sh $ADMIRAL_HOME, the installation will fail with error: resource mapping not found for name: "globaltrafficpolicies.admiral.io" namespace: "" from "/Users/tibers/Downloads/admiral-install-v1.2/yaml/remotecluster.yaml": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1beta1". This is because CRDs are now apiextensions.k8s.io/v1.

Expected behavior
It just works.

Fixing that leads to:

error: error validating "/Users/tibers/Downloads/admiral-install-v1.2/yaml/remotecluster.yaml": error validating data: [ValidationError(CustomResourceDefinition.spec): unknown field "version" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): missing required field "versions" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec]; if you choose to ignore these errors, turn validation off with --validate=false
namespace/admiral unchanged
error: error validating "/Users/tibers/Downloads/admiral-install-v1.2/yaml/demosinglecluster.yaml": error validating data: [ValidationError(CustomResourceDefinition.spec): unknown field "version" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec, ValidationError(CustomResourceDefinition.spec): missing required field "versions" in io.k8s.apiextensions-apiserver.pkg.apis.apiextensions.v1.CustomResourceDefinitionSpec]; if you choose to ignore these errors, turn validation off with --validate=false

It's extremely likely the whole project needs to be freshened up.

Related: #264

@tibers tibers added the bug Something isn't working label Apr 10, 2023
@aattuluri aattuluri added help wanted Extra attention is needed hacktoberfest issue open for hackoberfest contribution labels Sep 8, 2023
@ku9nov
Copy link

ku9nov commented Feb 2, 2024

Hey @aattuluri
A pull request was merged to support Kubernetes version 1.22, but after that, you did not create a new release and did not update this documentation, making it impossible to install Admiral based on this documentation. I think it's a main problem.

@nirvanagit
Copy link
Collaborator

@ku9nov: the readme has been updated, can you please try now?
@tibers: can you please retry now.

We recently pushed a lot of pending changes to upstream.
Please let me know.

@ku9nov
Copy link

ku9nov commented Sep 2, 2024

Hello @nirvanagit, Unfortunately, it was a long time ago, and I don't remember exactly how I encountered this problem, but I do know that we ultimately do not use Admiral for this cluster, and all the functionality was configured using Istio, which is fully sufficient for our needs. Thank you.

@aattuluri
Copy link
Contributor

Validated with k8s 1.28 and everything works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest issue open for hackoberfest contribution help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants