Mirror Destinationrule connectionPool to Sidecar #1754
Conversation
istio-testing
added
the
do-not-merge/work-in-progress
google-cla
bot
added
the
cla: yes
|
Skipping CI for Draft Pull Request. |
istio-testing
added
the
size/L
| @@ -448,6 +448,9 @@ message Sidecar { | |||
| // detected defaults from the namespace-wide or the global default Sidecar. | |||
| repeated IstioEgressListener egress = 3; | |||
|
|
|||
| // Settings controlling the volume of connections to an upstream service | |||
| istio.networking.v1alpha3.ConnectionPoolSettings connection_pool = 7; | |||
There was a problem hiding this comment.
I think the open question here that I didn't notice in the original design is where exactly we put this. In destination rule, we have the top level setting and perPortSettings. However for Sidecar we don't have this. If we put it here, users cannot configure it per-port. If we put in in Ingress, then users need to opt into explicitly configuring ALL ports just to add connection pool settings
There was a problem hiding this comment.
You need to add it in both places I'm guessing like how DR is structured.
| @@ -448,6 +448,9 @@ message Sidecar { | |||
| // detected defaults from the namespace-wide or the global default Sidecar. | |||
| repeated IstioEgressListener egress = 3; | |||
|
|
|||
| // Settings controlling the volume of connections to an upstream service | |||
There was a problem hiding this comment.
I will update comment later
|
@howardjohn: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
istio-testing
added
the
needs-rebase
|
@louiscryan @costinm can you take a look at this? |
Design
https://docs.google.com/document/d/1bIuwv0E98kyn8VZ_CDVGcZziIHyr3-ACiTmPqGgp5uY