Fix docs for protocol detection timeout #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
howardjohn
requested review from
brian-avery,
linsun,
louiscryan,
nrjpoddar and
smawson
as code owners
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/XS
nrjpoddar
reviewed
Oct 12, 2021
| @@ -54,7 +54,7 @@ message MeshConfig { | |||
| // the specified period, defaulting to non mTLS plain TCP | |||
| // traffic. Set this field to tweak the period that Envoy will wait | |||
| // for the client to send the first bits of data. (MUST BE >=1ms or | |||
| // 0s to disable). Default detection timeout is 5s. | |||
| // 0s to disable). Default detection timeout is 0s (no timeout). | |||
There was a problem hiding this comment.
@howardjohn when was this changed or were the docs always outdated?
There was a problem hiding this comment.
istio/istio@47a5927 looks like 1.9
ericvn
approved these changes
Oct 13, 2021
hzxuzhonghu
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.