Allow setting excludeNamespaces #3285
Conversation
|
😊 Welcome @hzxuzhonghu! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/XS
|
@hzxuzhonghu: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| // in these namespaces are all ignorred. It works in collaboration with `discoverySelectors` | ||
| // A request to the service or pod can succeed or fail depends on the `outboundTrafficPolicy`. | ||
| // If `outboundTrafficPolicy` is ALLOW_ANY, it can succeed, otherwise it can fail. | ||
| repeated string exclude_namespaces = 67; |
There was a problem hiding this comment.
which one takes precedence if a namespace is listed here but is selected by discovery selector?
There was a problem hiding this comment.
will still be excluded
There was a problem hiding this comment.
Why do we need another selector on top of discoverySelectors?
There was a problem hiding this comment.
discoverySelectors can already do this with kubernetes.io/metadata.name NOT IN <some name>
There was a problem hiding this comment.
If use discoverySelectors, user should set all the namespaces they want to use. On the contrary, it would be much simpler to exclude a small bunch of namespaces
There was a problem hiding this comment.
You can do "metadata.name NotIn [kube-system, istio-system]"
For istio/istio#52343