Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zirain as ENV Maintainers #861

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

zirain
Copy link
Member

@zirain zirain commented Nov 5, 2022

I've been working on both operator and installation components and contributed to components in docs, operator and tests. Love to be a maintainer to take on more work.

The most common reason to send a PR to this repository is to join the Istio org. If you are joining, please fill out this template. If you are not, please delete all the below.

List your company name, or indicate Individual if you're not affiliated with a company:

Provide a link to at least one PR that you have successfully pushed to one of the Istio repos:

istio/istio#41786
istio/istio#41756
istio/istio#41712
istio/istio#41644
istio/istio#41594
istio/istio#41575
istio/istio#41573
istio/api#2515
istio/istio#41449
istio/istio#41399
istio/istio#41330
istio/istio.io#12069
istio/istio#41322
istio/istio#40797
istio/istio#40757
istio/istio#40756
istio/istio#40727
istio/istio.io#11734
istio/istio#40606
istio/istio#40297
istio/istio#39988
istio/istio#39833
istio/istio#39781
istio/istio#39146
istio/istio.io#11355
istio/istio#38467
istio/istio#38146
istio/istio#38142

@zirain zirain requested a review from a team as a code owner November 5, 2022 08:44
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2022
@craigbox
Copy link
Contributor

craigbox commented Nov 7, 2022

please get an ack here from an Environments WG lead and we can merge!

Copy link
Contributor

@litong01 litong01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much. Love to have him as the maintainer

@ericvn
Copy link
Contributor

ericvn commented Nov 7, 2022

No objection from T&R WG lead. Welcome.

@irisdingbj
Copy link
Member

Thanks @zirain love to have him as ENV maintainer.

@istio-testing istio-testing merged commit e05accf into istio:master Nov 7, 2022
@zirain zirain deleted the add-zirain-to-env branch November 8, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants