-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run istioctl verify-install fail on demo profile #39146
Conversation
@@ -161,6 +161,7 @@ type ( | |||
} | |||
meshConfigExtensionProvider struct { | |||
Name string `json:"string"` | |||
EnvoyOtelAls struct{} `json:"envoyOtelAls"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine to make forward progress but aren't there like 10 other ones that are not captured here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I'm finding out a way to fix the others, need more time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@howardjohn update the implement and add a test prevent miss implement once there's a new provider.
/test integ-security-multicluster_istio |
1 similar comment
/test integ-security-multicluster_istio |
In response to a cherrypick label: #39146 failed to apply on top of branch "release-1.13":
|
In response to a cherrypick label: new issue created for failed cherrypick: #39242 |
In response to a cherrypick label: new pull request created: #39243 |
* run istioctl verify-install fail on demo profile * add release-notes * fix FuzzOverlayIOP * update and add exhaustive test * fix lint
Please provide a description of this PR:
fix: #38940
run istioctl verify-install fail on demo profile