run istioctl verify-install fail on demo profile #39146
Merged
+190
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/M
GregHanson
approved these changes
May 26, 2022
howardjohn
reviewed
May 26, 2022
| @@ -161,6 +161,7 @@ type ( | |||
| } | |||
| meshConfigExtensionProvider struct { | |||
| Name string `json:"string"` | |||
| EnvoyOtelAls struct{} `json:"envoyOtelAls"` | |||
There was a problem hiding this comment.
Fine to make forward progress but aren't there like 10 other ones that are not captured here?
There was a problem hiding this comment.
yes, I'm finding out a way to fix the others, need more time.
There was a problem hiding this comment.
@howardjohn update the implement and add a test prevent miss implement once there's a new provider.
istio-testing
added
size/L
howardjohn
approved these changes
Jun 1, 2022
|
/test integ-security-multicluster_istio |
1 similar comment
|
/test integ-security-multicluster_istio |
|
In response to a cherrypick label: #39146 failed to apply on top of branch "release-1.13": |
|
In response to a cherrypick label: new issue created for failed cherrypick: #39242 |
|
In response to a cherrypick label: new pull request created: #39243 |
zirain
added a commit
that referenced
this pull request
Jun 2, 2022
* run istioctl verify-install fail on demo profile * add release-notes * fix FuzzOverlayIOP * update and add exhaustive test * fix lint
istio-testing
pushed a commit
that referenced
this pull request
Jun 3, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
fix: #38940
run istioctl verify-install fail on demo profile